Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension development: Add debug-hover-like data navigation to regular hovers #81313

Closed
PEZ opened this issue Sep 23, 2019 · 8 comments
Closed
Assignees
Labels
api feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code

Comments

@PEZ
Copy link
Contributor

PEZ commented Sep 23, 2019

My extension (Calva, a Clojure extension) connects the editor view with the REPL running ”inside” the application under development. It blurs the borders between debugging and coding. In particular, you do not need to be in debug mode to query the value of some variable.

In Calva you can evaluate a form and see the result inline in the editor. I am right now adding a hover so that you can examine the results a bit closer. It looks like so:

image

For large data structures, this gets not so nice, though. It would be much better to present it like data is presented in debug hovers, where the user can navigate the data vi unfolding the pieces of interest.

@kieferrm kieferrm added the api label Sep 23, 2019
@octref octref added info-needed Issue requires more information from poster and removed api labels Sep 24, 2019
@octref
Copy link
Contributor

octref commented Sep 24, 2019

What you saw was likely a bug. Can you provide a minimal repro case by forking https://github.com/microsoft/vscode-extension-samples/tree/master/helloworld-sample?

Also I'm not sure what you meant by "where the user can navigate the data vi unfolding the pieces of interest".

@PEZ
Copy link
Contributor Author

PEZ commented Sep 25, 2019

@octref: My issue is probably too unclear. It is not a bug report, it is a feature request on the API.

Also I'm not sure what you meant by "where the user can navigate the data vi unfolding the pieces of interest".

When hovering over a variable in debug mode, and the value is some data structure, you get a tree view navigator UI. That is what I want to be able to create in non-debug hovers.

@octref octref added api and removed info-needed Issue requires more information from poster labels Sep 25, 2019
@octref
Copy link
Contributor

octref commented Sep 25, 2019

You'll need to get @jrieken interested, but my guess is this won't fit current API. We support MD in hover/completion/parameter-hints and so far there's no plan to add any interactivity over there.

@PEZ
Copy link
Contributor Author

PEZ commented Sep 25, 2019

@jrieken: Pretty please? ❤️ What can I add to the request to make its case better?

There is also #3220, even if that is much more general.

@octref
Copy link
Contributor

octref commented Sep 25, 2019

I doubt he'd be interested in doing this over doing #3220, which is more generic and covers this case.

@jrieken jrieken added editor feature-request Request for new features or functionality labels Oct 7, 2019
@jrieken jrieken removed their assignment Oct 7, 2019
@jrieken
Copy link
Member

jrieken commented Oct 7, 2019

Tbh this has no real chance of happening as our UX extensibility story is topic focused and rarely a general purpose story

@octref octref added the *out-of-scope Posted issue is not in scope of VS Code label Oct 16, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 16, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 16, 2019
@octref
Copy link
Contributor

octref commented Oct 16, 2019

Now you are limited to MD. Track #3220 for more possibilities in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

4 participants