Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: Console feels janky on high frequency output #81464

Closed
joaomoreno opened this issue Sep 26, 2019 · 6 comments
Closed

Debug: Console feels janky on high frequency output #81464

joaomoreno opened this issue Sep 26, 2019 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues tree-widget Tree widget issues
Milestone

Comments

@joaomoreno
Copy link
Member

Running our selfhost unit tests seems much slower than running it in a terminal. Hypothesis: tree isn't performing well enough for this scenario. We might need a specialized tree API for this.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug debug-console tree-widget Tree widget issues labels Sep 26, 2019
@joaomoreno joaomoreno changed the title Debug: Console has poor perf Debug: Console has poor performance Sep 26, 2019
@isidorn isidorn added this to the October 2019 milestone Sep 26, 2019
@isidorn
Copy link
Contributor

isidorn commented Sep 26, 2019

Assignign to October so we look into this next milestone.

@joaomoreno
Copy link
Member Author

Actually forget about this.... it's actually as fast as on the terminal... it's the perceived performance which sucks since rendering is debounced and everything feels sluggish.

@isidorn
Copy link
Contributor

isidorn commented Sep 26, 2019

Maybe I can decrease the debounce time.
Or we can test the limits of the tree and I no longer de-bounce

@joaomoreno joaomoreno changed the title Debug: Console has poor performance Debug: Console feels janky on high frequency output Sep 26, 2019
@joaomoreno
Copy link
Member Author

joaomoreno commented Sep 26, 2019

I think you're gonna have to keep the debounce since the current approach is still refresh(root). We're basically O(n^3) right now. If we add some tree API for you to simply append children then we can reduce the whole thing to O(n).

@isidorn
Copy link
Contributor

isidorn commented Oct 22, 2019

I do not think we do not plan to do anything this milestone.
When we add new tree api we can look into simply adopting that api in the debug console.
Anyways pushing to backlog.

@isidorn
Copy link
Contributor

isidorn commented Nov 2, 2020

Closing as out of scope, and we can reopen if we ever get passionate about this

@isidorn isidorn closed this as completed Nov 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues tree-widget Tree widget issues
Projects
None yet
Development

No branches or pull requests

3 participants