Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal output tab - autoopen problem #81522

Closed
ashot5706 opened this issue Sep 26, 2019 · 18 comments
Closed

terminal output tab - autoopen problem #81522

ashot5706 opened this issue Sep 26, 2019 · 18 comments
Assignees

Comments

@ashot5706
Copy link

Issue Type: Bug

terminal output tab everytime opens and shows info about parsing files, when I close tab, it reopens after delay

VS Code version: Code 1.36.1 (2213894, 2019-07-08T22:55:08.091Z)
OS version: Linux x64 4.15.0-64-generic

System Info
Item Value
CPUs Intel(R) Core(TM) i5-3230M CPU @ 2.60GHz (4 x 2086)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: unavailable_off
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 0, 0, 0
Memory (System) 3.68GB (0.25GB free)
Process Argv --unity-launch
Screen Reader no
VM 0%
Extensions (3)
Extension Author (truncated) Version
gitlens eam 9.9.3
php-intellisense fel 2.3.13
smarty imp 0.3.0
@chrmarti
Copy link
Contributor

/needsMoreInfo

Does this occur with all extensions disabled? (F1 > Developer: Restart With Extensions Disabled or code --disable-extensions)

(Note that you are on an older version of VS Code, please update.)

@vscodebot vscodebot bot added the info-needed Issue requires more information from poster label Sep 27, 2019
@vscodebot
Copy link

vscodebot bot commented Sep 27, 2019

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

@chrmarti chrmarti self-assigned this Sep 27, 2019
@dextar47
Copy link

i am also facing the same problem. it is very much annoying

@chrmarti
Copy link
Contributor

@dextar1 Does this occur with all extensions disabled? (F1 > Developer: Restart With Extensions Disabled or code --disable-extensions)

@ashot5706
Copy link
Author

ashot5706 commented Sep 27, 2019

It has not opened again yet, I will try it, for more info logs come from PHP Language Server, is it mean that problem in extensions?

@chrmarti
Copy link
Contributor

/causedByExtension

Yes, please file an issue with the PHP extension you have installed.

@vscodebot vscodebot bot added the *caused-by-extension Issue identified to be caused by an extension label Sep 27, 2019
@vscodebot
Copy link

vscodebot bot commented Sep 27, 2019

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

@felixfbecker
Copy link
Contributor

@chrmarti this has already been filed on the PHP extension. vscode-languageserver-node has an option on when to reveal the output panel, and it defaults to OnError. The users who reported the issue reported that there was no error in the output channel. Therefor this seems to be a VS Code bug.

felixfbecker/vscode-php-intellisense#65 (comment)

@dorianfm
Copy link

dorianfm commented Oct 1, 2019

It feels like there should be a way to disable this automatic opening, even on error, when using extensions which do a lot of parsing, like vscode-php-intellisense - perhaps a global option that stops the tab being opened on errror, and a report of error counts on the bottom status bar which when clicked opens the output window?

@chrmarti chrmarti removed *caused-by-extension Issue identified to be caused by an extension info-needed Issue requires more information from poster labels Oct 1, 2019
@chrmarti chrmarti assigned dbaeumer and unassigned chrmarti Oct 1, 2019
@chrmarti chrmarti reopened this Oct 1, 2019
@dbaeumer
Copy link
Member

dbaeumer commented Oct 2, 2019

@felixfbecker this is actually fully under your control. The default is that the LSP client reveals the output channel if an error is logged into it. However when creating the client you can set this to Never. (see https://github.com/Microsoft/vscode-languageserver-node/blob/master/client/src/client.ts#L339).

If this doesn't work for you please open an issue in the vscode-languageserver repository.

@dbaeumer dbaeumer closed this as completed Oct 2, 2019
@dbaeumer
Copy link
Member

dbaeumer commented Oct 2, 2019

Just to be clear: the output channel comes to front if an error is logged to it which for example is the case when a server errors a response.

@felixfbecker
Copy link
Contributor

According to the comment linked above, there was no error in the output channel (I can't personally reproduce it, I'm only forwarding)

@dbaeumer
Copy link
Member

dbaeumer commented Oct 2, 2019

How does the output panel look like?

VS Code has no error concept in output channels. It is LSP specific (e.g. vscode-languageserver)

@ashot5706
Copy link
Author

ashot5706 commented Oct 7, 2019

@dbaeumer What you mean, saying how it's look like?

@ashot5706
Copy link
Author

ashot5706 commented Oct 7, 2019

here it is again
but as far as I understand it's extension bug because, this error was occurred when I deleted the folder, so why extension look for files which are not exists
vscode_parse_error

@ghost
Copy link

ghost commented Oct 10, 2019

Can you just add an option to not auto switch even if there is an output, because i have the same issue. It is fucking annoying as hell, when i try to type something in the terminal it switches me over to output every 0.3s. I really like the idea of an integrated terminal, but i have to use iterm2 for now because of this bug :(

@ashot5706
Copy link
Author

Can you just add an option to not auto switch even if there is an output, because i have the same issue. It is fucking annoying as hell, when i try to type something in the terminal it switches me over to output every 0.3s. I really like the idea of an integrated terminal, but i have to use iterm2 for now because of this bug :(

How to add this option?

@ghost
Copy link

ghost commented Oct 11, 2019

@ashot11091950 Seems like it is not a VS Code bug, its just a plugin "PHP Language Server" that is calling the reveal output aggressively. You have to report the issue to them. Until then you can just disable the PHP plugin, to find it just disable all the PHP one by one until the issue stops :)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants