Error when Download command is used on a folder

[roblourens]

• Connect to a remote
• Right click on a folder in the explorer
• Click "Download"
• See an error notification pop up, "Unable to open '': File is a directory"

But I do get the save as dialog and can download the folder.

[isidorn]

I am using the textFileService.saveAs.

The issue here is that the textFileService assumes that the resource passed is a file. Thus it tries to open it here

I believe this was not happening before. Did we change something in this area @bpasero

And yes it might be a bit weird that I am using the textFileService for downloading a folder. I am open for ideas.

[bpasero]

@isidorn this reproduces with 1.38.1 stable for me:

ITextFileService was never implemented in a way that you could use it with folders.

[isidorn]

Ok, sounds like debt. Let me assign to next milestone and we can then consider if I shuold use a different service or the TextFileService should handle folder (which does not seem like a good choice)

[bpasero]

I would probably have a new service for this. And I also wonder what this command should do for a folder: should it download a zipped version of the folder or each file individually?

The ITextFileService is more for dealing with resolved text models that are opened in the system, not so much for lowlevel file io like downloading.

[isidorn]

Downloading a zipped version sounds like too much work for the use (he has to unzip).
I think it should be more seamless, so we download the whole foder and than each file individually. If people complain that it is slow, we can introduce a heuristic such that for larger folders we download a zipped version.

[isidorn]

From Ben: I don’t think ITextFileService is the right place for downloading a folder. I would rather manually bring up a folder picker to ask the user for the target destination and then use IFileService.copy() for the operation to that target folder.

[isidorn]

@bpasero thanks for feedback. I am no longer using textFileService but I am using the fileDialogService and the fileService
@roblourens you can try it out and let me know how it behaves now for you. Thanks