Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Folder Opened missing twisties #81662

Closed
miguelsolorio opened this issue Sep 30, 2019 · 3 comments
Closed

No Folder Opened missing twisties #81662

miguelsolorio opened this issue Sep 30, 2019 · 3 comments
Assignees
@isidorn
Labels
debt Code quality issues file-explorer Explorer widget issues
Milestone
October 2019

Comments

@miguelsolorio
Copy link
Contributor

image

This is likely not using the tree widget so will need to add the icon classes to this.

FYI @isidorn
@miguelsolorio miguelsolorio self-assigned this Sep 30, 2019
@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons labels Sep 30, 2019
@miguelsolorio miguelsolorio added this to the September 2019 milestone Sep 30, 2019
@miguelsolorio
Copy link
Contributor Author

Fixed

image

@bpasero bpasero reopened this Oct 1, 2019
@bpasero bpasero added the debt Code quality issues label Oct 1, 2019
@bpasero bpasero modified the milestones: September 2019, October 2019 Oct 1, 2019
@bpasero
Copy link
Member

bpasero commented Oct 1, 2019

Can we revisit why the empty view is not calling super.renderHeader() in this case? I find it weird that a view would have to repeat code that is already there in the base type for rendering the twisty. Sounds like debt to me.

@bpasero bpasero added file-explorer Explorer widget issues and removed bug Issue identified by VS Code Team member as probable bug labels Oct 1, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 1, 2019

@bpasero Yes, I can look into this next week. You are correct, looks like debt.
@misolori thanks for fixing it for this milestone though.

@isidorn isidorn removed the icons-product Issues for in-product icons label Oct 1, 2019
@isidorn isidorn closed this as completed in bc83461 Oct 7, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debt Code quality issues file-explorer Explorer widget issues
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@bpasero @isidorn @miguelsolorio