Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: New Octicons outline style #81679

Closed
3 tasks done
miguelsolorio opened this issue Sep 30, 2019 · 3 comments
Closed
3 tasks done

Test: New Octicons outline style #81679

miguelsolorio opened this issue Sep 30, 2019 · 3 comments

Comments

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Sep 30, 2019

Refs: #76909

Complexity: 2

We've updated our version of Octicons to use our new outline style. This means that every previous icon is now mapped to an outline version. Please use our docs as a reference for the list of icons to test. Below are the areas that should be tested (you can compare with Stable as a reference to the original):

  • Status bar
  • Quick pick labels
  • Issue reporter (related issues)
  • Peek view (close button)
  • Extensions: workspace recommendations (viewlet header has download all and edit)
  • GitHub comment (edit and delete)
  • Diff line (show next/prev change)
  • Verify that the icons show up properly in each of those areas.

For the Status bar, you can create your own extension or use my sample that cycles through all of the icons after you click the status bar item. You can additionally install other extensions that add items to the status bar (GitHub PR, vscode-spotify, Live Share, etc.) and verify that the icons show up correctly.

@miguelsolorio miguelsolorio added this to the September 2019 milestone Sep 30, 2019
@alexdima alexdima removed their assignment Oct 1, 2019
@roblourens
Copy link
Member

Extensions: workspace recommendations (viewlet header has download all and edit)

Where is Download All?

@roblourens roblourens removed their assignment Oct 1, 2019
@miguelsolorio
Copy link
Contributor Author

@roblourens when you are on a workspace with extension recommendations, they're the actions in the workspace recommendations header:

image

@roblourens
Copy link
Member

Oh right I was just looking at "recommendations", thanks

@egamma egamma removed their assignment Oct 2, 2019
@alexdima alexdima closed this as completed Oct 2, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants