Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd+k cmd+k shortcut #81795

Closed
roblourens opened this issue Oct 1, 2019 · 3 comments
Closed

cmd+k cmd+k shortcut #81795

roblourens opened this issue Oct 1, 2019 · 3 comments
Assignees

Comments

@roblourens
Copy link
Member

roblourens commented Oct 1, 2019

We recently added cmd+k cmd+k as a shortcut for "Toggle Fold" but some of us were thinking that it is not a good choice. It is easy to trigger on accident while trying to hit another chord, and it could be very confusing to someone if their code disappears and they don't know how to unfold it.

Also, this shortcut is already used in the keyboard shortcuts JSON editor to add a shortcut, and this now breaks that and triggers Fold instead.

@Tyriar

@Tyriar
Copy link
Member

Tyriar commented Oct 1, 2019

I think we should leave cmd+k cmd+k unbound, also k isn't anywhere in "toggle fold" so it doesn't seem like an intuitive choice anyway.

@Tyriar Tyriar added this to the September 2019 milestone Oct 1, 2019
@aeschli
Copy link
Contributor

aeschli commented Oct 2, 2019

Visual Studio uses Ctrl + M - Ctrl + M, and that's why I ended up with Ctrl + K Ctrl + K.
I'm fine to change it

@aeschli aeschli closed this as completed in 57aea60 Oct 2, 2019
@aeschli
Copy link
Contributor

aeschli commented Oct 2, 2019

I change it to Ctrl + M - Ctrl + L

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants