Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dead license link in win32 license.rtf agreement #81919

Closed
estevezluis1 opened this issue Oct 3, 2019 · 3 comments
Closed

dead license link in win32 license.rtf agreement #81919

estevezluis1 opened this issue Oct 3, 2019 · 3 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues verified Verification succeeded
Milestone
October 2019

Comments

@estevezluis1
Copy link

  • VSCode Version: 1.38.1 prod build
  • OS Version: Windows

Steps to Reproduce:

  1. Stop at first process of win32 installation, license agreement.
  2. Click on the link in the sentence "under the MIT license agreement at https://github.com/Microsoft/vscode/blob/master/license.txt."

The correct link is https://github.com/Microsoft/vscode/blob/master/LICENSE.txt
@joaomoreno joaomoreno added this to the October 2019 milestone Oct 7, 2019
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues labels Oct 7, 2019
@alexr00
Copy link
Member

alexr00 commented Oct 30, 2019

I tried to verify by installing insiders again, but it still has a broken link. Is this the correct way to verify?

@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Oct 30, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Oct 30, 2019 •
edited

Oh the Insiders might actually still be broken... I've only fixed it for stable.

@joaomoreno joaomoreno reopened this Oct 30, 2019
@joaomoreno joaomoreno removed the verification-steps-needed Steps to verify are needed for verification label Oct 30, 2019
@JacksonKearl JacksonKearl added verified Verification succeeded and removed verified Verification succeeded labels Oct 30, 2019
@JacksonKearl
Copy link
Contributor

Not yet in the build. Will check tomorrow.

@alexr00 alexr00 added the verified Verification succeeded label Oct 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
4 participants
@joaomoreno @JacksonKearl @estevezluis1 @alexr00