Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug nwjs debug breakpoint crash lost connection ? #82049

Closed
jonlepage opened this issue Oct 7, 2019 · 3 comments
Closed

bug nwjs debug breakpoint crash lost connection ? #82049

jonlepage opened this issue Oct 7, 2019 · 3 comments
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code

Comments

@jonlepage
Copy link

jonlepage commented Oct 7, 2019

  • VSCode Version:
    Version : 1.38.1 (user setup)
    Validation : b37e54c
    Date : 2019-09-11T13:35:15.005Z
    Électron : 4.2.10
    Chrome : 69.0.3497.128
    Node.js : 10.11.0
    V8 : 6.9.427.31-electron.0
    OS : Windows_NT x64 10.0.18362

  • OS Version:
    win10

Steps to Reproduce:

1.download nwjs sdk v.0.37.4 or upper >
https://dl.nwjs.io/
2. setup launch.json
image

            {
                "type": "nwjs",
                "request": "launch",
                "name": "Launch NWjs",
                "runtimeExecutable": "${workspaceRoot}\\_NW\\sdk\\nw.exe",
                "runtimeArgs": [
                    "--disable-raf-throttling",
                    "--remote-debugging-port=9222",
                ],
                "webRoot": "${workspaceRoot}",
                "port": 9222,
                "reloadAfterAttached": true,
                "sourceMaps": false,
            },
  1. try debug make some crash
    const a = 0; const a = 1;
    and try many refresh, close, you will see something wrong.
    Sometime app not close ?
    sometime debug breakpoint not work (not focus on vscode) !
    sometime app need focus to boot !!
    really mess here.

i made a video to show the behavior.
https://youtu.be/4JG19JX3c_w

@jonlepage
Copy link
Author

jonlepage commented Oct 7, 2019

after investigation , it seem those command will break vscode connection
So if you add this before a vscode breakpoint or a crash.
Vscode will no break (freeze) the nwjs app.

            win.showDevTools()
            win.maximize()
            win.focus();

i think focus on app when is boot cause the issue with vscode ?.

@jonlepage
Copy link
Author

ho ok, the coupable is win.showDevTools()
When we do this before crash point or breakpoint, this remove vscode connection !
Is a bug for nwjs team or vscode team ?
i don't know how the vscode engine work under hood sorry.

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Oct 7, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 7, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

2 participants