Terminal and part of the debug changes needed to respond to cancelling a prelaunch task #82255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a prelaunch task Part of #81768
|
@Tyriar to confirm terminal changes @isidorn The task events fire before the run task returns with the nice task summary with undefined exit code. I think changing the order of the task events is dangerous, so I have made a change in debug code to handle the case where the prelaunch task is terminated early. |
|
Looks good from the debug standpoint. Just format it a bit, and maybe add a comment, looks pretty cryptic at the moment. |
isidorn
approved these changes
Oct 10, 2019
Tyriar
approved these changes
Oct 10, 2019
|
Added a detailed comment explaining what's up. I also removed a redundant background check condition. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #81768