Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Unable to open a workspace with absolute paths on windows #82589

Closed
bpasero opened this issue Oct 15, 2019 · 4 comments
Closed

Web: Unable to open a workspace with absolute paths on windows #82589

bpasero opened this issue Oct 15, 2019 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded web Issues related to running VSCode in the web workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 15, 2019

Folders having absolute windows paths inside a workspace configuration file are not supported in web.

Reply from @aeschli

Absolute path in workspace files can be formatted as be os paths (c:\ddd). To be able to correctly resolve that for remote workspaces, we need to pass the platform of the workspace file to toWorkspace

Agree that this needs to be fixed, but IMO using absolute paths in the workspace file is not recommended and should be avoided. From what I know, we always create relative paths if possible.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug web Issues related to running VSCode in the web labels Oct 15, 2019
@bpasero bpasero added this to the October 2019 milestone Oct 15, 2019
@bpasero bpasero added the workbench-multiroot Multi-root (multiple folders) issues label Oct 15, 2019
@aeschli
Copy link
Contributor

aeschli commented Oct 21, 2019

@bpasero What do you suggest we do?
How was that workspace file created? IMO that's the problematic point.

@bpasero
Copy link
Member Author

bpasero commented Oct 21, 2019

@aeschli should have made clear, I only moved the issue. @lramos15 reported it. Maybe @sbatten and @sandy081 also have additional context.

However, given that someone may just check in a workspace file to a repository with absolute paths, I guess we could always end up in that situation.

@sbatten
Copy link
Member

sbatten commented Oct 21, 2019

Copied from previous issue:

@bpasero @aeschli I created my workspace file by saving workspace as and it used absolute paths.

To reproduce that on Windows, I open a folder in VS Code at C:\Users\sbatten\Source\folder then save the workspace as C:\Users\sbatten\Desktop\workspace.code-workspace

@aeschli
Copy link
Contributor

aeschli commented Oct 29, 2019

@sbatten Can you verify? You know the setup.

@sbatten sbatten added the verified Verification succeeded label Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded web Issues related to running VSCode in the web workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

3 participants