Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Support for translations/language packs #82595

Closed
bpasero opened this issue Oct 15, 2019 · 28 comments
Closed

Web: Support for translations/language packs #82595

bpasero opened this issue Oct 15, 2019 · 28 comments
Assignees
Labels
feature-request Request for new features or functionality L10N Translation issue on-testplan web Issues related to running VSCode in the web
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 15, 2019

Currently we do not support switching display language in the web.

@bpasero bpasero added feature-request Request for new features or functionality L10N Translation issue web Issues related to running VSCode in the web labels Oct 15, 2019
@dbaeumer dbaeumer self-assigned this Oct 28, 2019
@dbaeumer dbaeumer added this to the Backlog milestone Oct 28, 2019
@yuxuan
Copy link

yuxuan commented Mar 17, 2020

We currently mainly depend on VSCode web. And our main language is not English. It would be great helpful to us if VSCode web can support localization on web. Thanks.

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 3, 2022

Hi there!

I'm one of the maintainers of coder/code-server. We've (@code-asher and myself) modified our vscode fork to support changing the display language. Here is the PR: coder#34

@TylerLeonhardt I see you're planning to look into this for Jan. 2022. Is this something we can help with?

@TylerLeonhardt
Copy link
Member

@jsjoeio If I understand the change correctly, you essentially offload all translation handling to the remote side? Yeah this would be generally good for any "server-full" vscode offerings. If you would like to contribute a similar change, we'd love that!

That solution won't work for serverless environments like vscode.dev so we'll have to approach that differently.

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 7, 2022

@TylerLeonhardt yes! Awesome. I'll see if I can get started on this next week.

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 1, 2022

Heads-up. Some other priorities have come up and I haven't been able to get to this yet. I hope to soon, but if not, someone else feel free to tackle.

@Mister-Hope
Copy link

Mister-Hope commented Feb 4, 2022

Emm, this issue title is hard to search, could we mention it in https://code.visualstudio.com/docs/getstarted/locales that it's not supported on the web yet and ask user to track this issue?

Also, could we change the issue title into something like "Language pack support for web"? It's exacly the last 3 duplicate issue title

@TylerLeonhardt
Copy link
Member

@gregvanl what are your thoughts on updating the doc that @Mister-Hope suggested?

@TylerLeonhardt TylerLeonhardt changed the title Web: Support for translations Web: Support for translations/language packs Feb 4, 2022
@TylerLeonhardt
Copy link
Member

@jsjoeio FYI, I may end up tackling the part that you did later this month (translations working when there's compute on the server side) because it's a feature we're looking to light up.

I just wanna let you know because I think it would be awesome to see this contributed by the community especially since you already did the work basically :) but also no pressure whatsoever. If you beat me to it, awesome. If not, totally fine of course!

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 7, 2022

Oh awesome!

I agree, it would be really cool for us to contribute that back :) Well, if I can squeeze it in this month, I will. Thanks for the heads-up!

@gregvanl
Copy link

gregvanl commented Feb 9, 2022

Added mention that VS Code for the Web doesn't support Language Packs microsoft/vscode-docs@da8ff66

@TylerLeonhardt
Copy link
Member

🌐 ⚠️ 📣 I have published a new version of vscode-nls and merged in the PRs (one and two) into Core that should enable translations for the web for built-in extensions. I have also updated Azure Repos extension as the guinea pig to make sure this all works properly.

This means that at this point, all “feature bits” are done with translations for the web. We just have some bugs to iron out. Since those bugs are tracked in other issues I will close this now.

Tomorrow, all built-in extensions should be localized and the Azure Repos extension. If all goes smoothly, I'll start updating other extensions to take advantage of these changes.

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 9, 2022

@TylerLeonhardt that's wonderful to hear! When will this be available in Core/Stable release?

(asking because that will allow us to remove our patch)

@TylerLeonhardt
Copy link
Member

Unfortunately, I need to reopen this as we need to take a slightly different approach.

@vedg
Copy link

vedg commented Aug 22, 2022

We need this feature for https://github.com/microsoft/vscode-dev/issues/477 as well.

@TylerLeonhardt
Copy link
Member

With the new l10n API that has been finalized, this item is "done". #164438 will track onboarding built-in extensions to the new API.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality L10N Translation issue on-testplan web Issues related to running VSCode in the web
Projects
None yet
Development

Successfully merging a pull request may close this issue.