Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"There are task errors" while typing in tasks.json #82623

Open
roblourens opened this issue Oct 15, 2019 · 6 comments
Open

"There are task errors" while typing in tasks.json #82623

roblourens opened this issue Oct 15, 2019 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue tasks Task system issues
Milestone

Comments

@roblourens
Copy link
Member

  • Have a task like this:
{
	"type": "npm",
	"script": "web",
	"label": "Run web",
	"isBackground": true,
	"presentation": {
		"reveal": "never"
	}
}
  • Add this
"problemMatcher": {
	"background": {

	}
},
  • Get a warning popup immediately, "There are task errors. See the output for details"
  • I'm still typing, I know there are errors, it should leave me alone for a minute or until I close the editor
@roblourens
Copy link
Member Author

It's good to know that my task isn't correct but can it just be shown as an underline in the editor?

@alexr00 alexr00 added polish Cleanup and polish issue tasks Task system issues labels Oct 16, 2019
@alexr00 alexr00 added this to the October 2019 milestone Oct 16, 2019
@alexr00
Copy link
Member

alexr00 commented Oct 18, 2019

Context for why this was added: #76138 (comment)

@alexr00
Copy link
Member

alexr00 commented Oct 18, 2019

I'll add a debounce delay to config changes.

@alexr00
Copy link
Member

alexr00 commented Oct 18, 2019

I added a 1 second debounce to try to balance getting early feedback on your task being incorrect and getting the notification immediately

@alexr00 alexr00 reopened this Oct 30, 2019
@alexr00 alexr00 modified the milestones: October 2019, On Deck Oct 30, 2019
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Nov 9, 2020
@alexr00 alexr00 assigned meganrogge and unassigned alexr00 Jun 30, 2022
@meganrogge
Copy link
Contributor

I've encountered this too.

couldn't we update without the delay but if something is not correct, wait 20 seconds, check again, then decide whether or not to show the error notification?

@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2022

We should align with how language servers/lint extensions normally work imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue tasks Task system issues
Projects
None yet
Development

No branches or pull requests

4 participants