Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occurrences markers in scrollbar are indistinguishable from brackets #82961

Closed
joaomoreno opened this issue Oct 21, 2019 · 2 comments
Closed

Occurrences markers in scrollbar are indistinguishable from brackets #82961

joaomoreno opened this issue Oct 21, 2019 · 2 comments
Assignees
@alexdima
Labels
editor-bracket-matching Editor brace matching feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2019

Comments

@joaomoreno
Copy link
Member

With the introduction of highlighting the nearest wrapping brackets I've hit this situation many times in which I believe there are more occurrences of a variable than there actually are. This is because there is no distinction in the scrollbar between the other occurrences of the currently selected variable and the nearest wrapping brackets.

In the following screenshot, my variable only has one other occurrence, yet I see 4 markers in the scrollbar:

Screenshot from 21 10 2019 11:16:15
@joaomoreno
Copy link
Member Author

joaomoreno commented Oct 21, 2019 •
edited

One idea is to color the brackets differently. Another is to omit them from the scrollbar if the cursor is not on top of a bracket. I prefer the latter.

@alexdima alexdima added editor-bracket-matching Editor brace matching feature-request Request for new features or functionality labels Oct 22, 2019
@alexdima alexdima added this to the October 2019 milestone Oct 22, 2019
@joaomoreno
Copy link
Member Author

Thank you!

@alexdima alexdima added the verification-needed Verification of issue is requested label Oct 28, 2019
@jrieken jrieken added the verified Verification succeeded label Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
editor-bracket-matching Editor brace matching feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @alexdima