Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems: Improve filter text #8305

Closed
bpasero opened this issue Jun 28, 2016 · 5 comments
Closed

Problems: Improve filter text #8305

bpasero opened this issue Jun 28, 2016 · 5 comments
Assignees
Labels
error-list Problems view feature-request Request for new features or functionality ux User experience issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 28, 2016

Refs: #7601

I was initially confused by the filter text "Filter by type or text" because I did not make the connection from "type" to problem type.

I would make it more explicit: "Filter by problem type or text".

@weinand who is best in finding good wording :)

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug error-list Problems view labels Jun 28, 2016
@sandy081
Copy link
Member

I would probably call it simply "Filter", since one can filter by

  • type
  • description
  • source
  • file name

@weinand
Copy link
Contributor

weinand commented Jun 29, 2016

@sandy081 I agree, getting a description of all the different filter types into the initial text is not possible.
So "Filter" sounds ok to me.
But there is still a need for some guidance or help:
Could intellisense be used? You could propose the available problem types and file names.
Or you could have a longer description in some hover?

@sandy081
Copy link
Member

@weinand I think intellisense would be very nice, but that needs coming up with some grammar/standard to provide the filter which probably does not worth for this filter box.

I think for this case, just providing information would be sufficient.
To have an hover we need some filter icon which has to be in textbox. I had a filter icon in the beginning but removed it later. We can also check with UX for this

@sandy081 sandy081 added ux User experience issues and removed bug Issue identified by VS Code Team member as probable bug labels Jun 29, 2016
@sandy081 sandy081 added this to the July 2016 milestone Jul 5, 2016
@sandy081 sandy081 modified the milestones: Backlog, July 2016 Jul 26, 2016
@sandy081 sandy081 added the feature-request Request for new features or functionality label Aug 22, 2016
@sandy081 sandy081 changed the title Problems: filter text could improve Problems: Improve filter text Nov 27, 2017
@oriash93
Copy link
Contributor

Might be solved already, look at #22289 and commit 6f32564.

@sandy081
Copy link
Member

sandy081 commented May 2, 2018

Yeah, it got better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-list Problems view feature-request Request for new features or functionality ux User experience issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants