Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal colors are different (lighter) after upgrading to macOS Catalina #83130

Closed
ay0o opened this issue Oct 23, 2019 · 5 comments
Closed

Terminal colors are different (lighter) after upgrading to macOS Catalina #83130

ay0o opened this issue Oct 23, 2019 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@ay0o
Copy link

ay0o commented Oct 23, 2019

  • VSCode Version: 1.39.2
  • OS Version: macOS Catalina 10.15

Steps to Reproduce:

  1. Upgrade to macOS Catalina and notice the color change right away.
  2. If you are already on macOS Catalina, open terminal / iTerm and compare with VSCode's terminal.

Images:

VSCode:
Screenshot 2019-10-23 at 09 19 47

iTerm2 / Terminal:
Screenshot 2019-10-23 at 09 17 41

Back in Mojave there was no such difference. VSCode's terminal displayed the same color.

@vscodebot
Copy link

vscodebot bot commented Oct 23, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@Tyriar
Copy link
Member

Tyriar commented Oct 23, 2019

The colors the terminal draws is based on the vscode theme. You can try change the renderer to see if that changes the colors https://github.com/microsoft/vscode/wiki/Terminal-Issues#rendering-problems

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Oct 23, 2019
@ay0o
Copy link
Author

ay0o commented Oct 23, 2019

Tried both renderers, neither seem to impact the color. With the dom-based renderer the font looks slightly bigger, but that's all, nothing else changes.

@Tyriar
Copy link
Member

Tyriar commented Oct 23, 2019

@ay0o pretty sure your theme is saying to use that color then? You can set them in settings manually:

image

@ay0o
Copy link
Author

ay0o commented Oct 24, 2019

yes @Tyriar , you are right that I can manually force them to match the color I want by manually setting each of them, but this wasn't the behavior prior to the update to macOS Catalina, that's why I opened this ticket.

Before, both VSCode and iTerm2 had the same scheme without manual changes. In either case, I'm closing the ticket as the solution is as simple as:

  1. Open iTerm2 / Terminal
  2. Copy the color code (in my case, ansi blue and green)
  3. Force that setting in VSCode's settings.json

@ay0o ay0o closed this as completed Oct 24, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants