Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outline view for Markdown symbols shows key icon #83395

Closed
gregvanl opened this issue Oct 27, 2019 · 5 comments
Closed

Outline view for Markdown symbols shows key icon #83395

gregvanl opened this issue Oct 27, 2019 · 5 comments
Assignees
@miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded
Milestone
October 2019

Comments

@gregvanl
Copy link

  • VSCode Version: 1.40 Insiders
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open a Markdown file with some number of H1 and H2 headers
  2. Expand the Outline view

The symbol icon for Markdown headers had been an "abc" icon and not it is a confusing key icon.

Stable:

image

Insiders:

image
@gregvanl
Copy link
Author

The key icon is also displayed in breadcrumbs

image

@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons labels Oct 28, 2019
@miguelsolorio miguelsolorio added this to the October 2019 milestone Oct 28, 2019
@miguelsolorio
Copy link
Contributor

Good catch, this should be updated properly now:

image

@svipas
Copy link
Contributor

svipas commented Oct 28, 2019

I also saw the same issue in suggestion widget with word based suggestions thought to create an issue, could you check @misolori is it still shows key icon in suggestion widget or abc as supposed to? Thanks!

@miguelsolorio
Copy link
Contributor

@svipas this is fixed where all symbols are shown: outline, breadcrumb, and suggest widget. This also affected strings and text kinds.

image

@svipas
Copy link
Contributor

svipas commented Oct 28, 2019

@misolori Thanks! Nice work! 🚀

@gregvanl gregvanl added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@svipas @gregvanl @miguelsolorio