Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose QuickPick.matchOnLabel publicly #83425

Open
rmanthorpe opened this issue Oct 28, 2019 · 3 comments
Open

Expose QuickPick.matchOnLabel publicly #83425

rmanthorpe opened this issue Oct 28, 2019 · 3 comments
Assignees
@TylerLeonhardt
Labels
api feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Milestone
Backlog

Comments

@rmanthorpe
Copy link

matchOnLabel already exists as an internal API. It makes sense to apply it externally too. It could maintain the same semantics and would allow users to have a better control over the display of quickpick results. This was already suggested in #73904 (comment).
@chrmarti chrmarti added api feature-request Request for new features or functionality quick-pick Quick-pick widget issues labels Oct 28, 2019
@rmanthorpe
Copy link
Author

@chrmarti would you consider this change? It's trivial to implement and an obvious missing feature.

This was referenced Feb 20, 2020
Open
Open
@rmanthorpe rmanthorpe mentioned this issue Aug 25, 2020
Open
@rmanthorpe
Copy link
Author

@chrmarti I'd really like some input on this.

@TylerLeonhardt
Copy link
Member

Hi @rmanthorpe 👋 sorry for the delay. I now own the QuickPick space :) I would be willing to accept a PR for this feature since it's already available in the core product. Wanna give it a go?

@TylerLeonhardt TylerLeonhardt added this to the Backlog milestone Oct 21, 2021
@millerdev millerdev mentioned this issue Feb 25, 2022
Closed
@millerdev millerdev mentioned this issue Dec 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
api feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@TylerLeonhardt @rmanthorpe @chrmarti