Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32.findExecutable should check if the found file entry is a file and ignore directories. #83509

Closed
dbaeumer opened this issue Oct 29, 2019 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

See dotnet/vscode-csharp#3372 for a full explanation on what the underlying problem is.

The code part to be fixed in VS Code is here: instead of doing an exist we should stat and check whether it is a directory or a file. Only if it is a file we should return.

https://github.com/Microsoft/vscode/blob/master/src/vs/base/node/processes.ts#L467

@dbaeumer dbaeumer added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Oct 29, 2019
@dbaeumer dbaeumer modified the milestones: November 2019, October 2019 Oct 29, 2019
@dbaeumer
Copy link
Member Author

Should try to fix this for October.

@connor4312
Copy link
Member

I can verify the resolution, but the user reported earlier today it's still happening for him. Following up on the linked issue.

@connor4312
Copy link
Member

The commit fixed one issue which I easily reproduced and verified on Windows, but it appears to be different than the one that the user is running into (see dotnet/vscode-csharp#3372 (comment))

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants