Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification icon color descriptions #83554

Closed
RMacfarlane opened this issue Oct 29, 2019 · 1 comment
Closed

Notification icon color descriptions #83554

RMacfarlane opened this issue Oct 29, 2019 · 1 comment
Assignees
@miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded
Milestone
October 2019

Comments

@RMacfarlane
Copy link
Contributor

Testing #83479

Currently the text for the new notification colors is:
"The color used for the notification warning icon."

I suggest changing this to "The color used for the icon of warning notifications. Notifications slide in from the bottom right of the window." to match the existing notification color descriptions and gives more context
@miguelsolorio miguelsolorio added the bug Issue identified by VS Code Team member as probable bug label Oct 29, 2019
@miguelsolorio miguelsolorio added this to the October 2019 milestone Oct 29, 2019
@miguelsolorio miguelsolorio added the icons-product Issues for in-product icons label Oct 29, 2019
@joaomoreno joaomoreno added the verified Verification succeeded label Oct 30, 2019
@joaomoreno
Copy link
Member

Verified by code review.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@joaomoreno @RMacfarlane @miguelsolorio