Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve one task quickpick behavior #83648

Closed
alexr00 opened this issue Oct 30, 2019 · 4 comments
Closed

Improve one task quickpick behavior #83648

alexr00 opened this issue Oct 30, 2019 · 4 comments
Assignees
Labels
polish Cleanup and polish issue tasks Task system issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Oct 30, 2019

#40508 (comment)

@alexr00 alexr00 added tasks Task system issues polish Cleanup and polish issue labels Oct 30, 2019
@alexr00 alexr00 added this to the November 2019 milestone Oct 30, 2019
@alexr00 alexr00 self-assigned this Oct 30, 2019
@alexr00
Copy link
Member Author

alexr00 commented Oct 30, 2019

@chrmarti I'm not sure this will work. The previous quick pick is the command palette. Is there any better way to do this than with a cancellation token(which is what I'm doing now)?

@chrmarti
Copy link
Contributor

I don't think there is. The problem with the current approach is that the QuickPick already opens with a progress indicator expecting the list items to become available. So there will always be either a flicker or the QuickPick showing a single element.

One alternative could be to wait for the list to resolve for a few hundred milliseconds before opening the QuickPick and not open it if the list resolves with a single element before that timer expires.

If that doesn't help also consider going back to a single element QuickPick. Or maybe there is a valuable addition to the list you haven't implemented yet?

If the command palette knew that the command might open a QuickPick, it could just stay open with a progress indicator, but that needs more thought on how to implement and might be best addressed after the command palette has moved over to use the QuickInput widget.

@alexr00
Copy link
Member Author

alexr00 commented Oct 30, 2019

The flashing quick pick only happens if you toggle the setting to skip the quick pick when there's only one task (not default), so I think it's ok to leave since the value gained is a run experience with fewer clicks.

The few hundred milliseconds wait is a nice idea. I think that will take care of most cases because when there is only one task it is likely to be quick anyway.

@alexr00 alexr00 modified the milestones: November 2019, October 2019 Oct 30, 2019
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Nov 1, 2019
@alexr00
Copy link
Member Author

alexr00 commented Nov 1, 2019

Actually already verified by @connor4312

@alexr00 alexr00 added the verified Verification succeeded label Nov 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Cleanup and polish issue tasks Task system issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants