Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #81964 #83660

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Fixes #81964 #83660

merged 1 commit into from
Oct 31, 2019

Conversation

joaomoreno
Copy link
Member

This PR fixes #81964

There was a strange indirection in which the environment service was read upon the first getAccessibilitySupport() call. This makes sure to initialize _accessibilitySupport properly in the ctor. It also makes sure not to send the telemetry event more than once per session.

cc @isidorn

@joaomoreno joaomoreno added this to the October 2019 milestone Oct 30, 2019
@joaomoreno joaomoreno self-assigned this Oct 30, 2019
@bpasero bpasero assigned bpasero and unassigned bpasero Oct 30, 2019
@joaomoreno joaomoreno merged commit b10d698 into master Oct 31, 2019
@joaomoreno joaomoreno deleted the joao/fix-81964 branch October 31, 2019 08:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data for how many screen reader users we have
2 participants