Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors from evaluateRequest should be red in the debug console #83668

Closed
DanTup opened this issue Oct 30, 2019 · 3 comments
Closed

Errors from evaluateRequest should be red in the debug console #83668

DanTup opened this issue Oct 30, 2019 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@DanTup
Copy link
Contributor

DanTup commented Oct 30, 2019

If evaluateRequest sends an error response, it's coloured red in the Watch window, but just white in the Debug Console. I think it should also be read in the debug console so it's clear it was an error response.

Screenshot 2019-10-30 at 3 30 46 pm

Screenshot 2019-10-30 at 3 30 52 pm

protected evaluateRequest(response: DebugProtocol.EvaluateResponse, args: DebugProtocol.EvaluateArguments) {
	response.success = false;
	response.message = message;
	this.sendResponse(response);
}
@weinand weinand assigned isidorn and unassigned weinand Oct 31, 2019
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Oct 31, 2019
@weinand weinand added this to the November 2019 milestone Oct 31, 2019
@isidorn isidorn closed this as completed in 3e27bb0 Dec 2, 2019
@isidorn isidorn added the verification-needed Verification of issue is requested label Dec 2, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 2, 2019

@DanTup you can try it out in tomorrow's vscode insiders and let us know if this is now fixed for you. Thanks!

@DanTup
Copy link
Contributor Author

DanTup commented Dec 3, 2019

Fix LGTM, thanks!

(the directional arrows here are really nice too!)

Screenshot 2019-12-03 at 10 33 03 am

@isidorn
Copy link
Contributor

isidorn commented Dec 3, 2019

Thanks, adding verified label.

@isidorn isidorn added the verified Verification succeeded label Dec 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants