Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install extension on the server from extension viewlet #83675

Closed
kieferrm opened this issue Oct 30, 2019 · 9 comments
Closed

Can't install extension on the server from extension viewlet #83675

kieferrm opened this issue Oct 30, 2019 · 9 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

Testing #83500.

  1. Create an extension with the following snippet in package.json:
	"extensionKind": [ "ui", "workspace" ],
  1. Create vsix
  2. Open a remote SSH workspace
  3. Install vsix
    -> extension is installed locally, i.e. on the UI side
    -> Extension does not show the green batch to be installed on the remote box. I'd expect this to be there as the extension can support both locations.
@alexdima alexdima assigned sandy081 and unassigned alexdima Nov 8, 2019
@sandy081
Copy link
Member

As per my understanding this is an extension that preferably runs on local extension host if exists on both (local and remote). For eg., theme extensions.

So, is it expected to install such extension on both sides when asked to install?

@sandy081 sandy081 added ~info-needed Issue requires more information from poster (with bot comment) extensions Issues concerning extensions labels Nov 11, 2019
@vscodebot vscodebot bot added info-needed Issue requires more information from poster and removed ~info-needed Issue requires more information from poster (with bot comment) extensions Issues concerning extensions labels Nov 11, 2019
@vscodebot
Copy link

vscodebot bot commented Nov 11, 2019

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

@kieferrm
Copy link
Member Author

I don't expect it to be installed on both side. What I expected was that once it's installed on one side that there is an intuitive way for me to install it on the "other" side. Admittedly, that would complicate the UI but at the same time we support a user setting for it.

@sandy081
Copy link
Member

How will it be helpful for the user to have a button to install on remote given that this extension preferably runs on UI side. It means this action just install the extension on the remote which will not run in the current window. IMO an UI action which is prominent should be useful after applying.

@kieferrm
Copy link
Member Author

I manage extensions not just for the current client but also for VSO or other installs of VS Code. So, installing an extension as a workspace extension might not have an immediate effect but is still important to me.

@sandy081
Copy link
Member

For such case, instead of a prominent UI button, we shall allow user install UI extensions on remote using a command. We already have a command Install Extension in Remote which allows only workspace extensions. I will include all workspace (workspace, ui+workspace) extensions here.

@vscodebot vscodebot bot closed this as completed Nov 25, 2019
@vscodebot
Copy link

vscodebot bot commented Nov 25, 2019

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 9, 2020
@sandy081 sandy081 added extensions Issues concerning extensions feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Jan 28, 2020
@sandy081 sandy081 added this to the Backlog milestone Jan 28, 2020
@sandy081 sandy081 reopened this Jan 28, 2020
@sandy081 sandy081 modified the milestones: Backlog, February 2020 Jan 29, 2020
@sandy081 sandy081 modified the milestones: February 2020, On Deck Feb 20, 2020
@sandy081 sandy081 modified the milestones: On Deck, April 2020 Mar 31, 2020
@sandy081 sandy081 modified the milestones: April 2020, May 2020 Apr 28, 2020
@sandy081
Copy link
Member

sandy081 commented May 5, 2020

Added following support

  • Show Install Action if the extension is not running on the preferable location. For eg., if extension's kind is ["workspace", "ui"](preferable workspace) and running locally and other way around.

  • Command Remote: Install Local Extensions in Remote shows all can installable remote extensions.

@sandy081 sandy081 added the verification-needed Verification of issue is requested label May 5, 2020
@sandy081
Copy link
Member

sandy081 commented Jun 1, 2020

To verify, in a remote window

  • Make sure Install on Remote action is shown when an extension with extension kind - ["workspace", "ui"]or ["ui", "workspace"] or ["workspace"] is installed locally. You can use Docker extension and you can configure extension kind using remote.extensionKind setting.

  • Make sure the command Remote: Install Local Extensions in Remote shows all extensions those can be installed on remote. These extensions are those with extension kind - ["workspace", "ui"]or ["ui", "workspace"] or ["workspace"]

@connor4312 connor4312 added the verified Verification succeeded label Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants