Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax highlighting for diff in Markdown codeblock #83683

Closed
zachvalenta opened this issue Oct 30, 2019 · 3 comments
Closed

syntax highlighting for diff in Markdown codeblock #83683

zachvalenta opened this issue Oct 30, 2019 · 3 comments
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension grammar Syntax highlighting grammar markdown Markdown support issues

Comments

@zachvalenta
Copy link

At present, code blocks have syntax highlighting in both the editor and in Markdown preview. The exact colors aren't a 1-to-1 match, but it's more or less the same.

  • editor
    Screen Shot 2019-10-30 at 2 59 29 PM

  • preview
    Screen Shot 2019-10-30 at 2 59 36 PM

For diff code blocks, however, the only highlighting comes in Markdown preview.

  • editor
    Screen Shot 2019-10-30 at 3 01 59 PM

  • preview
    Screen Shot 2019-10-30 at 3 02 11 PM

Be nice if this highlighting were also displayed in the editor.

@mjbvz mjbvz self-assigned this Oct 30, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 30, 2019

Works for me in VS Code and in the current insiders build:

Screen Shot 2019-10-30 at 4 47 42 PM

This is likely theme specific. What theme are you using?

/needsMoreInfo

@vscodebot vscodebot bot added the info-needed Issue requires more information from poster label Oct 30, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 30, 2019

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

@mjbvz mjbvz added grammar Syntax highlighting grammar markdown Markdown support issues labels Oct 30, 2019
@zachvalenta
Copy link
Author

Yep, it is the theme :/

sorry for the bother!

@mjbvz mjbvz added *caused-by-extension Issue identified to be caused by an extension and removed info-needed Issue requires more information from poster labels Oct 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension grammar Syntax highlighting grammar markdown Markdown support issues
Projects
None yet
Development

No branches or pull requests

2 participants