Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript assigns variable kind to constructor #83762

Closed
jrieken opened this issue Oct 31, 2019 · 2 comments
Closed

TypeScript assigns variable kind to constructor #83762

jrieken opened this issue Oct 31, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug outline Source outline view issues typescript Typescript support issues verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Oct 31, 2019

  • latest from master
  • configure: "outline.showConstructors": false
  • have the TS code below
  • 馃悰 the outline still shows the constructor because TS assign the variable type to it
class FooClass {

    foo = TextTrackCue;
    
    constructor() {
        
    }

    bar() {
        let hidden = 234;
        hidden **=2;
        return hidden;
    }
}
@jrieken jrieken assigned jrieken and mjbvz and unassigned jrieken Oct 31, 2019
@jrieken jrieken added this to the October 2019 milestone Oct 31, 2019
@jrieken
Copy link
Member Author

jrieken commented Oct 31, 2019

This is a little unfortunate because filtering local variables are the driving force behind the filtering feature...

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug outline Source outline view issues typescript Typescript support issues labels Oct 31, 2019
@jrieken jrieken self-assigned this Oct 31, 2019
@jrieken
Copy link
Member Author

jrieken commented Oct 31, 2019

@mjbvz pushed a fix for this

@connor4312 connor4312 added the verified Verification succeeded label Oct 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug outline Source outline view issues typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants