Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Welcome Page header in web. #83862

Merged
merged 1 commit into from Nov 1, 2019

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Nov 1, 2019

This PR fixes the header when Code is running in Web.

import { localize } from 'vs/nls';

export default () => `
<div class="welcomePageContainer">
<div class="welcomePage">
<div class="title">
<h1 class="caption">${escape(localize('welcomePage.vscode', "Visual Studio Code"))}</h1>
<h1 class="caption">${escape(isWeb ? localize('welcomePage.vscodeonline', 'Visual Studio Online') : localize('welcomePage.vscode', "Visual Studio Code"))}</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quotes

@rebornix rebornix merged commit 77607b3 into microsoft:release/1.40 Nov 1, 2019
@rebornix rebornix deleted the rebornix/web branch November 1, 2019 23:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants