Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send data directly to appender in web telemetry, without formatting #83949

Merged
merged 1 commit into from Nov 4, 2019
Merged

Send data directly to appender in web telemetry, without formatting #83949

merged 1 commit into from Nov 4, 2019

Conversation

RMacfarlane
Copy link
Contributor

@RMacfarlane RMacfarlane commented Nov 4, 2019 •
edited by Tyriar

The validate method both performs some checks on the data, and sorts it into properties and measurements based on type. This is called again within the appender, which was causing data to be double-nested within "properties" properties

@RMacfarlane RMacfarlane self-assigned this Nov 4, 2019
@Tyriar Tyriar added this to the October 2019 milestone Nov 4, 2019
@RMacfarlane RMacfarlane merged commit d39e6b3 into release/1.40 Nov 4, 2019
@RMacfarlane RMacfarlane deleted the rmacfarlane/telemetryFormatting branch November 4, 2019 22:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@RMacfarlane RMacfarlane

Labels
None yet
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RMacfarlane @Tyriar