Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code action intellisense in the keybindings JSON editor #84033

Closed
mjbvz opened this issue Nov 6, 2019 · 3 comments
Closed

Code action intellisense in the keybindings JSON editor #84033

mjbvz opened this issue Nov 6, 2019 · 3 comments
Assignees
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 6, 2019

Feature request

When creating a keybinding for a specific code action, such as:

	{
		"key": "shift+ctrl+e",
		"command": "editor.action.codeAction",
		"args": {
			"kind": "refactor.extract",
			"preferred": true
		}
	}

We should show intellisense for the args property and also intellisense for code action kind by leveraging the new contribution point from #82718

/cc @sandy081

@mjbvz mjbvz added this to the November 2019 milestone Nov 6, 2019
@mjbvz mjbvz self-assigned this Nov 6, 2019
@mjbvz mjbvz closed this as completed in 166f925 Nov 6, 2019
@mjbvz
Copy link
Contributor Author

mjbvz commented Nov 6, 2019

@sandy081 Please take a look at the changes in 166f925. I added a new method in KeybindingService to support contributing a dynamic json schema for a command. This seemed like the clearest way to achieve this

@mjbvz mjbvz added editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Nov 6, 2019
@sandy081
Copy link
Member

sandy081 commented Nov 7, 2019

@alexandrudima owns this code and hence mentioning him.

@alexdima
Copy link
Member

👍

@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants