Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show what specific type of refactorings/codeActions are not available when requesting explicit ones #84096

Closed
mjbvz opened this issue Nov 7, 2019 · 0 comments
Assignees
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 7, 2019

Repo

  1. Create a keybinding for extract constant:
	{
		"key": "ctrl+shift+e",
		"command": "editor.action.codeAction",
		"args": {
			"kind": "refactor.extract.constant",
			"preferred": true
		}
	}
  1. Open a js file
  2. Select something that cannot be extracted and use keyboard shortcut

Feature Request
Show error message specifically saying that no refactor.extract.constant refactorings are available

Today we just show a generic message that no refactorings are available

@mjbvz mjbvz added feature-request Request for new features or functionality editor-code-actions Editor inplace actions (Ctrl + .) labels Nov 7, 2019
@mjbvz mjbvz added this to the November 2019 milestone Nov 7, 2019
@mjbvz mjbvz self-assigned this Nov 7, 2019
@mjbvz mjbvz closed this as completed in 060770b Nov 7, 2019
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Dec 2, 2019
@connor4312 connor4312 added the verified Verification succeeded label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants