Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git: Support ignoring comments out of a restored commit template file #84274

Closed
joaomoreno opened this issue Nov 8, 2019 · 3 comments
Closed

Git: Support ignoring comments out of a restored commit template file #84274

joaomoreno opened this issue Nov 8, 2019 · 3 comments
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality git GIT issues

Comments

@joaomoreno
Copy link
Member

From @gaetawoo at #81569 (comment)
@joaomoreno joaomoreno added feature-request Request for new features or functionality git GIT issues labels Nov 8, 2019
@joaomoreno joaomoreno added this to the November 2019 milestone Nov 8, 2019
@joaomoreno joaomoreno self-assigned this Nov 8, 2019
@joaomoreno
Copy link
Member Author

Setting is git.restoreCommitTemplateComments

@joaomoreno joaomoreno mentioned this issue Nov 8, 2019
Closed
@joaomoreno joaomoreno removed this from the November 2019 milestone Nov 21, 2019
@joaomoreno
Copy link
Member Author

joaomoreno commented Nov 21, 2019 •
edited

@gaetawoo I will have to revert this setting. I can no longer respect comments in the input box. The input box will be taken literally until further work. More info: #84201 (comment)

@ghost
Copy link

ghost commented Nov 21, 2019

@joaomoreno wow... I was gonna be sad and then I read all those other issues and though... my usecase isn't that big of a problem. Lol.

But I do agree with one of the last commenters saying that it should just be a basic text input taken literally... and should NOT use the git message template as a starting point. That's how it was forever, and it seems like me and others liked it that way. Just ignore the git template for that box. It's too small a box for the template to be useful anyway to my mind, and it's not monospaced, etc.. it's not a text editor.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality git GIT issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joaomoreno