Debug: Icon issues in call stack view

[joaomoreno]

The disconnect icon is missing:

Vertical alignment is broken:

Icon visibility is broken in a selected yet not focused row (click row and press Down):

Icon visibility for disabled actions isn't great for selected and focused rows:

Weird mouse hover behavior:

[isidorn]

@joaomoreno nice catches. I have pushed a fix which tackles everything except the "Disabled action visibility is not great for selected items". That one I leave up to @misolori if he would like to tackle.

Also note that the vertical alignment I got with the vertical-align: text-top. I am open for suggestions on a nicer solution, though this seems to work fine.

Let me know how it behaves now.

[miguelsolorio]

I think that it should still look disabled in the active/selected state, I'll take that one.

Also concerned that the stop icon looks like this:

Will look into this as well.

[miguelsolorio]

Actually, the disabled opacity is set to 40% across all disabled items in the product, which I don't think we should change:

vscode/src/vs/base/browser/ui/actionbar/actionbar.css

Lines 53 to 56 in 8e1ce71

	.monaco-action-bar .action-item.disabled .action-label,
	.monaco-action-bar .action-item.disabled .action-label:hover {
	opacity: 0.4;
	}

[isidorn]

@misolori if you are refering to the centering regardign the stop icon: I should have fixed that.

[miguelsolorio]

@isidorn no, I meant how the stop icon is filled and not an outline. It should be like this (I already fixed this):

[isidorn]

Yes, that makes senst. Thanks!