CI for Monaco Editor compile and bundling. #84636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The checks failed https://github.com/microsoft/vscode/pull/84636/checks?check_run_id=300257810 due to the missing |
40 tasks
54 tasks
|
@alexdima thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting up the build/test pipeline for Monaco Editor, the pipeline was broken three times within two weeks for completely different reasons. It aligns with the experience of @alexandrudima and me publishing Monaco Editor each time: we usually spent hours to half a day digging into why we can't build a good binary from master with a single
editor-distro. Thus we decided to put the Compile/Build/TreeShake/Bundle checks into our CI. The checks will run in parallel and won't slow down the whole CI process.Smoke tests will stay in Monaco Editor repo right now.