Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#84696 Modify git add/revert to use splitInChunks #84843

Merged
merged 1 commit into from May 27, 2020
Merged

#84696 Modify git add/revert to use splitInChunks #84843

merged 1 commit into from May 27, 2020

Conversation

jzyrobert
Copy link
Contributor

This PR fixes #84696

Hi, this is my first time contributing to open source code.

  • Modified the add and revert functions to also split the commands across chunks, mainly copying it from the checkout function.
  • Modified paths.lengths to paths.length > 0 to be consistent with the previous PR adding chunk splitting. (TS 3.7 would allow for this to be paths?.length)

Is using a limiter necessary for either of the 2 functions?

If the revert command throws an error, is it necessary to deal with any chunks that would have already finished running?

@msftclas
Copy link

msftclas commented Nov 14, 2019

CLA assistant check
All CLA requirements met.

@jzyrobert jzyrobert changed the title Modify git add/revert to use splitInChunks #84696 Modify git add/revert to use splitInChunks Nov 14, 2019
@joaomoreno joaomoreno added the git GIT issues label Nov 15, 2019
@VVKot
Copy link

VVKot commented Nov 30, 2019

@joaomoreno Do you mind rerunning checks on this? I wanted to give a hand on this issue and fix tests, but it seems that all of the failing ones are flaky.

@jzyrobert
Copy link
Contributor Author

Should I rebase this onto master again?

@joaomoreno
Copy link
Member

@jzyrobert No, it's OK.

@nokternol
Copy link

Can we get this PR resolved? I am using insiders and keep butting up against this issue as I do a lot of architectural refactoring on a big project in vscode.

@jzyrobert
Copy link
Contributor Author

@joaomoreno I've rebased it on top of recent updates, do you have any opinions on this?

@joaomoreno joaomoreno added this to the May 2020 milestone May 27, 2020
@joaomoreno
Copy link
Member

Thanks! 🍻

@joaomoreno joaomoreno merged commit 9fcc5e8 into microsoft:master May 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git spawn ENAMETOOLONG when adding/removing a large directory
5 participants