Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry flipped cursor on line number #85176

Closed
MrConnorKenway opened this issue Nov 20, 2019 · 7 comments
Closed

Blurry flipped cursor on line number #85176

MrConnorKenway opened this issue Nov 20, 2019 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded
Milestone

Comments

@MrConnorKenway
Copy link

  • VSCode Version: 1.40.1
  • OS Version: macOS 10.15.1

Steps to Reproduce:

  1. Change the color theme to a dark theme
  2. Move the mouse cursor to the line numbers
  3. The mouse cursor blurs and it looks quite different from the system's default mouse cursor

image

image

Does this issue occur when all extensions are disabled?: Yes

Or maybe you can offer an option to disable the flipped cursor feature to solve this issue?

@alexdima
Copy link
Member

alexdima commented Nov 20, 2019

@misolori Here is the CSS we have for the inverse cursor on macOS:

.monaco-editor.mac .margin-view-overlays .line-numbers {
cursor: -webkit-image-set(
url('flipped-cursor-mac.svg') 1x,
url('flipped-cursor-mac-2x.svg') 2x
) 24 3, default;
}

@miguelsolorio
Copy link
Contributor

@alexandrudima what was the rationale for flipping the cursor in this instance? I always thought it was a bit odd.

@alexdima
Copy link
Member

I think we took it from Visual Studio or from Word, not 100% sure...

@miguelsolorio
Copy link
Contributor

@alexandrudima @rebornix what do you think about making this a regular cursor: pointer on hover instead of using a custom one? This would match all of our other hover cursors in the gutter:

@alexdima
Copy link
Member

@misolori We can try removing the flipped cursor, but I wouldn't make it a hand/pointer, I would just leave it as is... Having it be a pointer over the line numbers feels weird to me.

@miguelsolorio
Copy link
Contributor

I'm ok with the default cursor as well, the pointer was mostly to indicate that you can select an entire line.

@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons labels Dec 12, 2019
@miguelsolorio miguelsolorio added this to the December/January 2020 milestone Dec 12, 2019
@miguelsolorio
Copy link
Contributor

This now uses the default cursor (non-flipped) when hovering over line numbers:

image

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 26, 2020
@rebornix rebornix added the verified Verification succeeded label Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants