Add gulp targets, fix build for Windows on Arm. #85326

richard-townsend-arm · 2019-11-21T18:59:10Z

This PR partially fixes #33620, #81854

This PR doesn't get us all the way there because of a problem with vscode-sqlite3. (Essentially, it doesn't build with right version of Visual Studio - 2017 or later is needed, the node-gyp config is slightly wrong and I don't have legal approval to fix it). Once that issue is fixed, you'll be able to do the following to build for Windows on Arm, assuming Node v12.13.1 and node-gyp 5.0.5:

set npm_config_arch=arm64
yarn install --force
yarn run gulp vscode-win32-arm64-archive

Make sure to set up an ARM64 cross-compilation terminal as documented in Electron's upstream instructions.

The result is a zip file which you can manually install and run on the device - seems to work well, built-in extensions like syntax highlighting, PowerShell prompt all seem to function, performance is good too.

PTAL and I'll try to fix any non-SQLite issues which come up. CC @deepak1556

Update: 2020-March-10: the revised SQlite3 module has been published.

msftclas · 2019-11-21T18:59:23Z

All CLA requirements met.

richard-townsend-arm · 2019-11-21T19:26:10Z

build/npm/postinstall.js

 	console.log(`$ yarn ${args.join(' ')}`);
 	const result = cp.spawnSync(yarn, args, opts);
-
+	// Restore the architecture, if temporarily swapped.
+	process.env["npm_config_arch"] = oldConfigArch


I think the build error may come from here. Probably should strengthen the check so it fires only on Windows.

joaomoreno

Build error is this, notice the undefined:

LINK : fatal error LNK1104: cannot open file 'C:\Users\runneradmin\AppData\Local\node-gyp\Cache\12.4.0\undefined\node.lib' [D:\a\vscode\vscode\remote\node_modules\native-watchdog\build\watchdog.vcxproj]

build/lib/electron.js

build/npm/postinstall.js

voronoipotato · 2019-12-02T18:26:53Z

@richard-townsend-arm Don't forget to sign the CLA, that way it will get released :). I'm happy to help test this on my surface pro x.

richard-townsend-arm · 2019-12-02T18:39:34Z

OK, CLA is now signed. I meant to get another patchset out last week, but there've been a few last-minute issues before branching Chromium 80 / Electron 8 which have been consuming my attention. Hopefully get an update out in a few days time.

bpasero · 2019-12-05T10:05:42Z

Change itself looks OK to me, but I think we need to validate the build once we ran it since these changes are all in build scripts. Unassigning myself from review.

richard-townsend-arm · 2019-12-10T16:24:27Z

OK. I'm unsure why the CI is failing to fetch all the deps (something to do with --frozen-lockfile?) There haven't been any changes to packages.json so I'm unsure why it's doing this...

richard-townsend-arm · 2019-12-18T20:48:08Z

Cool, looks like the CI has come back clean this time. Ready for review.

richard-townsend-arm · 2020-01-06T21:04:03Z

Hi guys, happy new year! Any review thoughts?

snickler · 2020-01-08T05:38:23Z

I'd love to see this merged in soon. I built from your branch last month and it has been running perfectly for me on my Surface Pro X @richard-townsend-arm .

voronoipotato · 2020-01-09T14:46:43Z

Indeed do we have a date estimate for review @joaomoreno / @deepak1556 ? It appears that @richard-townsend-arm has completed your changes.

deepak1556

Sorry for the delay on this, LGTM

richard-townsend-arm · 2020-01-14T22:13:50Z

I'm not authorized to merge this change atm.

snickler · 2020-01-14T23:37:34Z

It needs @joaomoreno to review it before you can merge.

nathansoz · 2020-01-15T01:38:13Z

Would love to see this get merged soon! Built from source but am unable to use the remote development extensions :/

joaomoreno

Merging this will only enable building the OSS bits. We will not distribute whatever targets this enables building since that's a much much larger work item and infrastructure investment.

build/gulpfile.reh.js

build/gulpfile.vscode.win32.js

build/npm/postinstall.js

snickler · 2020-01-16T01:08:30Z

Merging this will only enable building the OSS bits. We will not distribute whatever targets this enables building since that's a much much larger work item and infrastructure investment.

Is there any guidance on the remaining things that would enable a true VS Code build for Windows ARM64? This is something that many of us running WoA would absolutely love to have.

joaomoreno · 2020-01-16T08:08:41Z

@snickler As you can imagine, writing the code to build VS Code is only half the story. We have a lot of infrastructure and manual steps to ensure the quality of the bits that we ship to our customers. Basically, if we distribute it, it becomes part of our endgame and continuous testing efforts. We currently don't have the hardware or selfhosting motivation to push this forward. Upvoting #33620 will help with that.

voronoipotato · 2020-01-16T22:04:10Z

@joaomoreno Firstly, thanks for taking the time to read and review the pull request. I understand this is a lot of extra work. VS Code and the work you do here is extremely important for Microsoft's Arm initiative. Visual Studio proper can't be meaningfully ported in the near future and emulation of Visual Studio just isn't there yet. Without a tool to write software for windows on ARM there never will be "software for windows on arm". VS Code should be the primary tool for writing code on ARM devices. If you aren't allocated the hardware to test this, and it has downstream impacts that might prevent ARM on windows from being a profitable niche, then that should be remedied. Perhaps you could reach out to the Dot Net team and see what they can do to help connect you with the resources so that ARM has a fair chance in the market. They are currently working on an installer for dotnet core on ARM, and it may be helpful to market this as a coordinated release. Again, thank you for having the patience and compassion to read through the code review. I know you're not heavily incentivized to merge in outside pull requests, so it means a lot. ❤️

dotnet/runtime#1529

hwchong · 2020-03-13T03:28:40Z

Would be great to have this merged. Is it just waiting for @joaomoreno to approve or were more changes requested? It looks like all the checks have passed at this point.

It's sad to think this is being blocked by internal politics at Microsoft.

harrisonmetz · 2020-03-14T08:42:39Z

Would be great to have this merged. Is it just waiting for @joaomoreno to approve or were more changes requested? It looks like all the checks have passed at this point.

It's sad to think this is being blocked by internal politics at Microsoft.

Internal politics? The PR is appropriately licensed, and if it works all that is left is to hit the merge button. It's not even that large of a code change. I'd be happy to click the merge button for someone else if they don't feel they can.

voronoipotato · 2020-03-17T18:27:20Z

I hope @joaomoreno is alright 😕, hopefully they're just on vacation and not hit with the virus.

voronoipotato · 2020-03-31T18:24:55Z

hello @joaomoreno ! It appears that you're back. Hopefully all is well. I understand that times have been rough for all and please take the time you need to recenter and breathe. Nobody is as productive as they would like during a pandemic.

If you find that you have the time it would mean a lot to us if you could merge even with an early access or alpha label that way people can use and install it but you don't have as much pressure to work tickets to resolve them, merely merging fixes as you can. Hopefully that could be a decent middle path that allows people to have an option. I personally have not been using my surface pro x as much as I would like in part because it has no native vscode. I really had expected Microsoft to have a unified approach but it appears they have left your team behind in resources. Sorry to hear about that, I think Code is one of Microsoft's best products.

joaomoreno · 2020-04-01T05:48:05Z

@voronoipotato, and everyone else: merging this PR does not mean, by all means, that we will start releasing VS Code for ARM. That is a whole different undertaking and requires proper planning and time and resource allocation for our PM team, who is very much aware of the demand for VS Code on ARM for Windows.

This PR will simply enable you to build the Code OSS build for Windows ARM. You can already do that today, you don't need to wait for me:

Clone this repo
Checkout this PR
Build

I will look into merging the PR in April.

snickler · 2020-04-01T22:06:03Z

@voronoipotato, and everyone else: merging this PR does not mean, by all means, that we will start releasing VS Code for ARM. That is a whole different undertaking and requires proper planning and time and resource allocation for our PM team, who is very much aware of the demand for VS Code on ARM for Windows.

This PR will simply enable you to build the Code OSS build for Windows ARM. You can already do that today, you don't need to wait for me:

Clone this repo

Checkout this PR

Build

I will look into merging the PR in April.

Nevertheless, we appreciate you looking into this. It'll make it easier for those who wish to create automated Code OSS builds for WoA. After what I've tried to do personally with building some of the components for ARM64, I definitely understand the amount of roadblocks involved with enabling this to be a fully supported VS Code build. After .NET 5 is released, I know a few of those roadblocks will be fixed.

If testers, or ANY help is desired - the team definitely has a group of people they can call upon.

I ask that each of us awaiting this, continue to be patient and contribute any way we can.

joaomoreno

I think we should focus on the client bits for now. Let's remove the unnecessary parts and get this in.

joaomoreno · 2020-04-08T11:51:10Z

build/gulpfile.reh.js

@@ -25,6 +25,7 @@ const cp = require('child_process');
 const REPO_ROOT = path.dirname(__dirname);

 const BUILD_TARGETS = [
+	{ platform: 'win32', arch: 'arm64', pkgTarget: 'node8-win-arm64' },


Let's remove this and focus on the client bits for now.

build/gulpfile.vscode.win32.js

joaomoreno · 2020-04-08T11:52:58Z

build/lib/electron.ts

@@ -107,7 +107,7 @@ function getElectron(arch: string): () => NodeJS.ReadWriteStream {
 	};
 }

-async function main(arch = process.arch): Promise<void> {
+async function main(arch = process.env["npm_config_arch"] || process.arch): Promise<void> {


We don't need this, since the build isn't fetching electron from here.

joaomoreno · 2020-04-08T11:53:24Z

build/npm/postinstall.js

 	if (result.error || result.status !== 0) {
 		process.exit(1);
 	}
 }

+function remoteOpts() {


Again, let's remove this and leave remote for another day.

joaomoreno · 2020-04-08T12:01:00Z

May I ask, how is anybody testing this? With what hardware?

snickler · 2020-04-08T12:05:33Z

I've tested this compiling it from my ASUS NovaGo and most recently my Surface Pro X using the instructions above. I was able to compile a build from this PR while even merging master into it. Sent from Outlook Mobile<https://aka.ms/blhgte>

…

________________________________ From: João Moreno <notifications@github.com> Sent: Wednesday, April 8, 2020 8:01:19 AM To: microsoft/vscode <vscode@noreply.github.com> Cc: Jeremy Sinclair <jeremy.sinclair@live.com>; Mention <mention@noreply.github.com> Subject: Re: [microsoft/vscode] Add gulp targets, fix build for Windows on Arm. (#85326) May I ask, how is anybody testing this? With what hardware? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode%2Fpull%2F85326%23issuecomment-610917179&data=02%7C01%7C%7Cbe342319d2e34384e9b508d7dbb48cee%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637219440805126929&sdata=8J34yN2lUCK6PKWFOzqx9HrbyRH7dX9ULj128mD8ZTY%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA6URJPNA7XG4HZLKFYMDOTRLRRQ7ANCNFSM4JQGXUWQ&data=02%7C01%7C%7Cbe342319d2e34384e9b508d7dbb48cee%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637219440805136926&sdata=aEGuSLMtTvUyg0kaLY47YFvRZb6NOAZ6jLcKsRNEINI%3D&reserved=0>.

hwchong · 2020-04-08T12:10:42Z

Surface Pro X here.

…

-------- Original message -------- From: Jeremy Sinclair <notifications@github.com> Date: 8/4/20 10:05 pm (GMT+10:00) To: microsoft/vscode <vscode@noreply.github.com> Cc: Hon Weng Chong <hon@corticallabs.com>, Comment <comment@noreply.github.com> Subject: Re: [microsoft/vscode] Add gulp targets, fix build for Windows on Arm. (#85326) I've tested this compiling it from my ASUS NovaGo and most recently my Surface Pro X using the instructions above. I was able to compile a build from this PR while even merging master into it. Sent from Outlook Mobile<https://aka.ms/blhgte>

________________________________ From: João Moreno <notifications@github.com> Sent: Wednesday, April 8, 2020 8:01:19 AM To: microsoft/vscode <vscode@noreply.github.com> Cc: Jeremy Sinclair <jeremy.sinclair@live.com>; Mention <mention@noreply.github.com> Subject: Re: [microsoft/vscode] Add gulp targets, fix build for Windows on Arm. (#85326) May I ask, how is anybody testing this? With what hardware? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode%2Fpull%2F85326%23issuecomment-610917179&data=02%7C01%7C%7Cbe342319d2e34384e9b508d7dbb48cee%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637219440805126929&sdata=8J34yN2lUCK6PKWFOzqx9HrbyRH7dX9ULj128mD8ZTY%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA6URJPNA7XG4HZLKFYMDOTRLRRQ7ANCNFSM4JQGXUWQ&data=02%7C01%7C%7Cbe342319d2e34384e9b508d7dbb48cee%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637219440805136926&sdata=aEGuSLMtTvUyg0kaLY47YFvRZb6NOAZ6jLcKsRNEINI%3D&reserved=0>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#85326 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAC734VEOOTYUVMSAICUWVDRLRSB3ANCNFSM4JQGXUWQ>.

harrisonmetz · 2020-04-08T12:13:25Z

Maybe Microsoft should send Surface Pro X's to the entire development team of VS code!

joaomoreno · 2020-04-08T12:26:27Z

Got it. Let's see if I can get my hands on one of those.

pmsjt · 2020-04-08T16:55:57Z

There are quite a few options available for ARM64 based devices. For doing dev work I'd certainly limit the options to those with 8GiB RAM or more. Surface ProX is an obvious choice, especially to MS employees who can get them internally. But the Yoga C630 is an inexpensive candidate, being featured for sale in many stores, being previous generation.

Qualcomm 8cx based:

Surface ProX
Samsung Galaxy Book S

Qualcomm 850 based:

Samsung Galaxy Book 2
Lenovo Yoga C630 Snapdragon

Qualcomm 835 based:

Asus NovaGo
HP Envy x2 Snapdragon
Lenovo Miix 630

voronoipotato · 2020-04-12T22:21:26Z

wixtoolset/issues#5558

Looks like wix is ready to go for this too!

snickler · 2020-04-12T22:26:58Z

wixtoolset/issues#5558

Looks like wix is ready to go for this too!

Yup. Hopefully the 3.14 release comes soon. I was able to pull THIS off using the latest WiX dev release (with a bunch of horrible changes that I could never commit lol)

https://twitter.com/sinclairinat0r/status/1241059487139717121

joaomoreno · 2020-04-14T11:29:07Z

This is now merged, so you should be able to compile VS Code for ARM.

There's a Surface Pro X on the way, so we'll be able to test this soon and evaluate having an official VS Code version.

voronoipotato · 2020-04-14T15:44:42Z

Thank you so much João!!! This means so much to me, I really appreciate it. I think once you realize just how amazing it is to not worry about outlets on the go or lugging around a heavy machine you will also come to love the Surface Pro x, and now the battery footprint of VSCode is going to be so tiny! It really is night and day. Truly the killer app for the killer laptop.

hwchong · 2020-04-14T23:28:33Z

Thank you very much for merging this and for working to implement full support for WOA! I've managed to transition almost all my development work to the Surface Pro X with the exception of remote WSL and C/CPP, and so I still keep the x86 binary around for that. Otherwise it works perfectly for most of the other interpreted languages 😊

deepak1556 requested review from joaomoreno, bpasero and deepak1556 November 21, 2019 19:16

richard-townsend-arm commented Nov 21, 2019

View reviewed changes

deepak1556 self-assigned this Nov 22, 2019

joaomoreno requested changes Nov 22, 2019

View reviewed changes

build/lib/electron.js Outdated Show resolved Hide resolved

build/npm/postinstall.js Outdated Show resolved Hide resolved

bpasero removed their request for review December 5, 2019 10:05

voronoipotato mentioned this pull request Dec 5, 2019

Missing Windows Arm64 installer dotnet/core#3765

Closed

richard-townsend-arm force-pushed the woa branch 2 times, most recently from edd2cd7 to 52d3410 Compare December 10, 2019 16:13

richard-townsend-arm requested a review from joaomoreno December 10, 2019 16:23

richard-townsend-arm force-pushed the woa branch from 52d3410 to 40d74d4 Compare December 18, 2019 20:04

deepak1556 approved these changes Jan 14, 2020

View reviewed changes

joaomoreno requested changes Jan 15, 2020

View reviewed changes

richard-townsend-arm force-pushed the woa branch from 40d74d4 to 8b73106 Compare January 16, 2020 17:36

kieferrm assigned joaomoreno and unassigned deepak1556 Mar 17, 2020

kieferrm added this to the April 2020 milestone Mar 17, 2020

joaomoreno requested changes Apr 8, 2020

View reviewed changes

joaomoreno added 4 commits April 14, 2020 13:21

address feedback

9267738

💄

82860b3

fix arm64

b925790

💄

2e0cf81

joaomoreno merged commit 3b19657 into microsoft:master Apr 14, 2020

davide-rota mentioned this pull request Apr 15, 2020

Win Arm64 (WoA) Build VSCodium/vscodium#379

Closed

joaomoreno mentioned this pull request Apr 22, 2020

Support ARM64 build for Windows #33620

Closed

dsugiyama mentioned this pull request May 17, 2020

Build errors attempting Code v1.45.0 dsugiyama/build-vscode-win-arm64#1

Closed

github-actions bot locked and limited conversation to collaborators May 29, 2020

Add gulp targets, fix build for Windows on Arm. #85326

Add gulp targets, fix build for Windows on Arm. #85326

Conversation

richard-townsend-arm commented Nov 21, 2019 • edited

msftclas commented Nov 21, 2019 • edited

richard-townsend-arm Nov 21, 2019

Choose a reason for hiding this comment

joaomoreno left a comment • edited

Choose a reason for hiding this comment

voronoipotato commented Dec 2, 2019

richard-townsend-arm commented Dec 2, 2019

bpasero commented Dec 5, 2019

richard-townsend-arm commented Dec 10, 2019

richard-townsend-arm commented Dec 18, 2019

richard-townsend-arm commented Jan 6, 2020

snickler commented Jan 8, 2020

voronoipotato commented Jan 9, 2020

deepak1556 left a comment

Choose a reason for hiding this comment

richard-townsend-arm commented Jan 14, 2020

snickler commented Jan 14, 2020

nathansoz commented Jan 15, 2020

joaomoreno left a comment

Choose a reason for hiding this comment

snickler commented Jan 16, 2020

joaomoreno commented Jan 16, 2020

voronoipotato commented Jan 16, 2020 • edited

hwchong commented Mar 13, 2020

harrisonmetz commented Mar 14, 2020

voronoipotato commented Mar 17, 2020

voronoipotato commented Mar 31, 2020 • edited

joaomoreno commented Apr 1, 2020 • edited

snickler commented Apr 1, 2020

joaomoreno left a comment • edited

Choose a reason for hiding this comment

joaomoreno Apr 8, 2020

Choose a reason for hiding this comment

joaomoreno Apr 8, 2020

Choose a reason for hiding this comment

joaomoreno Apr 8, 2020

Choose a reason for hiding this comment

joaomoreno commented Apr 8, 2020

snickler commented Apr 8, 2020 via email

hwchong commented Apr 8, 2020 via email

harrisonmetz commented Apr 8, 2020

joaomoreno commented Apr 8, 2020

pmsjt commented Apr 8, 2020

voronoipotato commented Apr 12, 2020

snickler commented Apr 12, 2020

joaomoreno commented Apr 14, 2020

voronoipotato commented Apr 14, 2020 • edited

hwchong commented Apr 14, 2020

richard-townsend-arm commented Nov 21, 2019 •

edited

msftclas commented Nov 21, 2019 •

edited

joaomoreno left a comment •

edited

voronoipotato commented Jan 16, 2020 •

edited

voronoipotato commented Mar 31, 2020 •

edited

joaomoreno commented Apr 1, 2020 •

edited

joaomoreno left a comment •

edited

voronoipotato commented Apr 14, 2020 •

edited