Explorer .gitignore integration considers git repo outside of workspace folder

[Tyriar]

Issue Type: Bug

I cloned xterm into vscode's node_modules and opened that folder, all files in the explorer are faded out despite being in an "inner" git repo.

VS Code version: Code - Insiders 1.41.0-insider (599c076, 2019-11-22T07:19:06.796Z)
OS version: Darwin x64 18.7.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2200)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off surface_control: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off webgl: enabled webgl2: enabled
Load (avg)	4, 3, 2
Memory (System)	16.00GB (0.20GB free)
Process Argv	-psn_0_11799360
Screen Reader	no
VM	0%

Extensions (15)

Extension	Author (truncated)	Version
vscode-svgviewer	css	2.0.0
EditorConfig	Edi	0.14.2
vscode-pull-request-github-insiders	Git	2019.11.2342
vscode-azureappservice	ms-	0.16.1
vscode-docker	ms-	0.8.2
vscode-language-pack-ja	MS-	1.40.2
remote-containers	ms-	0.85.0
remote-ssh-edit-nightly	ms-	2019.11.21120
remote-ssh-nightly	ms-	2019.11.21120
azure-account	ms-	0.8.7
vscode-typescript-tslint-plugin	ms-	1.2.3
debugger-for-chrome	msj	4.12.1
material-icon-theme	PKi	3.9.1
sort-lines	Tyr	1.9.0
vscode-todo-highlight	way	1.0.4

(2 theme extensions excluded)

[joaomoreno]

cc @jrieken Did you hit this before?

[jrieken]

🤷‍♂ the ignore-provider simply runs git check-ignore, no extra massage or anything like that

[joaomoreno]

They are ignored by one repo yet not ignored by another... I guess we never did really do decoration deduplication.

[jrieken]

They are ignored by one repo yet not ignored by another...

I'd say they are ignored then. I wouldn't know how to show UX for this otherwise - it would require something very SCM/git-specific that allows you to select the current repo.

[Tyriar]

Seems to not happen in a minimal test case? 🤔

That's 2 git repos with the outer one having this in .gitignore:

ignore.txt
test3