Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: call stack commands arguments #85696

Open
isidorn opened this issue Nov 27, 2019 · 0 comments
Open

Debug: call stack commands arguments #85696

isidorn opened this issue Nov 27, 2019 · 0 comments
Assignees
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Nov 27, 2019

We need to do a couple of things:

  1. Currently for commands which are contributed for threads we pass the threadId as a number argument. However this is not enough when you are debugging multiple sessions. Since the threadId does not uniquly identify the thread across sessions. Due to that we should send a structured object which contains the sessionId and the threadId
  2. For stackFrame we pass the source uri string. Which is also not enough to identify the stackFrame. It should laso include the threadId and the sessionId
  3. We need to add documention which explains what contexts we pass for contributed call stack commands

We will probably try not to break the current behavior, but add additional arugments after the current argument.

@testforstephen is Java contributing call stack commands for threads?
@roblourens @connor4312 fyi since the node debugging contribues Skip File commands
@weinand fyi

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues debt Code quality issues labels Nov 27, 2019
@isidorn isidorn added this to the December 2019 milestone Nov 27, 2019
@isidorn isidorn self-assigned this Nov 27, 2019
@isidorn isidorn modified the milestones: January 2020, On Deck Jan 22, 2020
@isidorn isidorn assigned roblourens and unassigned isidorn Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

2 participants