Incorrect keyboard shortcut shown in menu.

[ksze]

• VSCode Version: 1.40.2 (also happens in 1.41.0-insider)
• OS Version: Pop!_OS 19.10 64-bit (which is very much like Ubuntu 19.10 Eoan Ermine)

Steps to Reproduce:

1. Press Ctrl+K, Ctrl+S to open the keyboard shortcut editor;
2. Find the entry for toggling the Activity Bar (workbench.action.toggleActivityBarVisibility)
3. Set its keybinding to "Ctrl + Super + A", which shouldn't be used by anything else by default; "Super" is the "Windows" key on PC keyboards, also known as the meta key in Linux.
4. Close the keyboard shortcut editor;
5. Open the "View" menu --> "Appearance"
6. See that the keyboard shortcut displayed next to "Show Activity Bar" is "Ctrl+A" instead of "Ctrl+Super+A"

Does this issue occur when all extensions are disabled?: Yes

[sandy081]

Does the assigned keybinding works?

[ksze]

The keybinding (Ctrl+Super+A) does work.

[sbatten]

It seems that electron is just ignoring the super part of the shortcut even though is documented as supported. @deepak1556 let me know if we can't fix this on electron side and I will patch with our "non-native keybind" workaround

[yaitskov]

I struggle with that issue. I use Emacs keybindings, but menu still shows default shortcuts. So it is totally messed up!

[RichardFevrier]

Any Super/Meta keybind is ignored. Super/Meta + C to copy instead of Ctrl + C becomes just C.
On linux no matters xorg or wayland it is completely broken. Unusable for me.

[deepak1556]

This requires patch in https://source.chromium.org/chromium/chromium/src/+/main:ui/base/accelerators/accelerator.cc;l=396-405 and cannot be made easily. @sbatten a workaround on our end would be better here.