Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extension respect the window.openFoldersInNewWindow setting #85851

Closed
jonpetersathan opened this issue Oct 28, 2019 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues verified Verification succeeded
Milestone

Comments

@jonpetersathan
Copy link

It would be convenient, if the remote extension would also respect the window.openFoldersInNewWindow setting of vscode. This way you could use eg. code ./myproject instead of code -r ./myproject in a remote workspace to replace the current window.

@aeschli
Copy link
Contributor

aeschli commented Oct 28, 2019

Can you give details? Which remote extension? What are the steps to reproduce?

@jonpetersathan
Copy link
Author

This affects all remote extensions (SSH, Containers, WSL).

Steps to Reproduce

  • Change window.openFoldersInNewWindow to off in vscode settings
  • Open a remote workspace (eg. wsl ubuntu)
  • Run code ./myproject/ from the integrated terminal of the remote workspace

Current Behavior

  • VSCode opens up in a new window

Expected Behavior

  • VSCode should replace the current opened window with ./myproject/ (What happens if you run code --reuse-window ./myproject

The window.openFoldersInNewWindow option basically changes the default behavior of vscode on startup. If turned on (default) and another instance is started, vscode will open up in a new window. If this setting is turned off, vscode will replace the current opened window with the specified folder (in the example above ./myproject/.
This behavior can also be forced with the command line arguments --reuse-window or --new-window respectively.

@aeschli aeschli transferred this issue from microsoft/vscode-remote-release Nov 30, 2019
@vscodebot
Copy link

vscodebot bot commented Nov 30, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@aeschli aeschli added this to the November 2019 milestone Nov 30, 2019
@aeschli aeschli added remote Remote system operations issues bug Issue identified by VS Code Team member as probable bug labels Nov 30, 2019
@alexr00 alexr00 added the verified Verification succeeded label Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants