Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening remote file from cli is opening folder #85883

Closed
sandy081 opened this issue Oct 1, 2019 · 3 comments
Closed

Opening remote file from cli is opening folder #85883

sandy081 opened this issue Oct 1, 2019 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality remote Remote system operations issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Oct 1, 2019

Testing microsoft/vscode-remote-release#1526

code-insiders --remote ssh-remote+ubuntu16 /home/sandy081/work/vscode/package.json is opening folder package.json 馃悰

image

@aeschli
Copy link
Contributor

aeschli commented Oct 29, 2019

Yes, there is guessing involved. Maybe we can say that if it has a extension we treat it as a file. If ending with '/' then it's definitely a folder.

@aeschli aeschli transferred this issue from microsoft/vscode-remote-release Dec 1, 2019
@aeschli aeschli added this to the November 2019 milestone Dec 1, 2019
@aeschli aeschli added feature-request Request for new features or functionality remote Remote system operations issues labels Dec 1, 2019
@aeschli aeschli closed this as completed in f667462 Dec 1, 2019
@aeschli aeschli added the verification-needed Verification of issue is requested label Dec 3, 2019
@aeschli
Copy link
Contributor

aeschli commented Dec 3, 2019

Verify that when opening a remote resource, the folloeing rules are used:

  • it's a file if it ends with a file extension, but no trailing slash\backslash
  • it's a workspace file it it ends with .code-workspace
  • otherwise it's a folder

e.g.
code-insiders --remote ssh-remote+ubuntu16 /home/sandy081/work/vscode/package.json

@connor4312 connor4312 added the verified Verification succeeded label Dec 4, 2019
@connor4312
Copy link
Member

The guessing logic in general is rather unfortunate; I'm unable to open dotfiles or extension-less file, like Makefile, and with this folders that have a dot in their name will be opened as file. We do detect these after we connect, maybe we can automatically re-open the file or folder correctly if we guessed incorrectly?

image

Anyhow, I'm able to verify that the described behavior works, so I'll leave it as 'verified'.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality remote Remote system operations issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants