Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems: change color when item is selected #8620

Closed
bpasero opened this issue Jul 1, 2016 · 1 comment
Closed

Problems: change color when item is selected #8620

bpasero opened this issue Jul 1, 2016 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jul 1, 2016

As you can see in light theme it is hard to read all text. I suggest to change the color to white for all text for the selected item:

image

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug error-list Problems view labels Jul 1, 2016
@sandy081 sandy081 added this to the July 2016 milestone Jul 1, 2016
@sandy081
Copy link
Member

sandy081 commented Jul 7, 2016

Issue was I was using a different color for source label. Instead, I would use opacity of 0.7 so that other information is not as as prominent as problem description. At the same time, they are readable in all themes and when selected.

Since this is similar to file path, it will be consistent with how we render file path in the tree.

screen shot 2016-07-07 at 11 33 37 am

screen shot 2016-07-07 at 11 33 58 am

screen shot 2016-07-07 at 11 34 31 am

screen shot 2016-07-07 at 11 34 47 am

@jrieken jrieken added the verified Verification succeeded label Jul 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants