Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use markdownDescription and markdownEnumDescription in terminal contributions #86287

Closed
Tyriar opened this issue Dec 4, 2019 · 1 comment
Closed

Use markdownDescription and markdownEnumDescription in terminal contributions #86287

Tyriar opened this issue Dec 4, 2019 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
November 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 4, 2019

Needs a pass over terminal.contribution, for example:

vscode/src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts

Lines 208 to 212 in 1a32116

enumDescriptions: [
nls.localize('terminal.integrated.detectLocale.auto', "Set the `$LANG` environment variable if the existing variable does not exist or it does not end in `'.UTF-8'`."),
nls.localize('terminal.integrated.detectLocale.off', "Do not set the `$LANG` environment variable."),
nls.localize('terminal.integrated.detectLocale.on', "Always set the `$LANG` environment variable.")
],

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Dec 4, 2019
@Tyriar Tyriar added this to the November 2019 milestone Dec 4, 2019
@Tyriar Tyriar self-assigned this Dec 4, 2019
@Tyriar Tyriar closed this as completed in f42ab17 Dec 4, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Dec 4, 2019

To verify test the changed settings in f42ab17

@sandy081 sandy081 added the verified Verification succeeded label Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
2 participants
@Tyriar @sandy081