Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search view checkboxes use greyscale aa #86310

Open
sbatten opened this issue Dec 4, 2019 · 4 comments
Open

Search view checkboxes use greyscale aa #86310

sbatten opened this issue Dec 4, 2019 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug lcd-text-rendering
Milestone

Comments

@sbatten
Copy link
Member

sbatten commented Dec 4, 2019

image

not sure if this is equivalent to #85589 since the text in the box is using proper SPAA

refs #85143

@deepak1556
Copy link
Contributor

@sbatten this one is different, the textarea in the other issue is affected by the system font. I have an idea about the upstream issue thats causing it. Will post updates there tomorrow.

@roblourens roblourens added this to the December 2019 milestone Dec 4, 2019
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Dec 4, 2019
@bpasero
Copy link
Member

bpasero commented Dec 7, 2019

This came in from @misolori via c109f9a. It looks like the background color is set to transparent which likely causes this.

image

@bpasero bpasero assigned miguelsolorio and unassigned bpasero Dec 7, 2019
@miguelsolorio
Copy link
Contributor

I'll update this so it's only using a background when set.

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Dec 9, 2019

After looking into this, the transparent border/background is not affecting the grayscale, I added a new icon (plain) on a separate DOM node, and it is also affected:

image

What's interesting is if I play with the positioning, there's a threshold where it will switch from aa to grayscale, so it appears that the input is causing the grayscale:

gif

And hiding the input removes the grayscale aa:
image

@roblourens roblourens removed their assignment Jan 4, 2020
@miguelsolorio miguelsolorio modified the milestones: February 2020, Backlog Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug lcd-text-rendering
Projects
None yet
Development

No branches or pull requests

6 participants