Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload count escapes container #86334

Closed
Tyriar opened this issue Dec 4, 2019 · 1 comment
Closed

Overload count escapes container #86334

Tyriar opened this issue Dec 4, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 4, 2019

Testing #84682

The text escapes the box:

image

Removing min-width from .controls fixes the problem (but might cause other problems?)

@Tyriar
Copy link
Member Author

Tyriar commented Dec 4, 2019

Snippet to help test with TS:

  private _a(a: number, b: number, c: number, d: number): void;
  private _a(a: string, b: number, c: number, d: number): void;
  private _a(a: number, b: string, c: number, d: number): void;
  private _a(a: number, b: number, c: string, d: number): void;
  private _a(a: number, b: number, c: number, d: string): void;
  private _a(a: string, b: string, c: number, d: number): void;
  private _a(a: string, b: number, c: string, d: number): void;
  private _a(a: string, b: number, c: number, d: number): void;
  private _a(a: string, b: string, c: string, d: number): void;
  private _a(a: string, b: string, c: number, d: string): void;
  private _a(a: number, b: string, c: string, d: string): void;
  private _a(a: number, b: string, c: number, d: string): void;
  private _a(a: number, b: number, c: string, d: string): void;
  private _a(a: number | string, b: number | string, c: number | string, d: number | string): void {
    this._a(
  }

@mjbvz mjbvz added this to the November 2019 milestone Dec 4, 2019
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Dec 4, 2019
@mjbvz mjbvz closed this as completed in 02a1ddc Dec 4, 2019
@eamodio eamodio added the verified Verification succeeded label Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants