Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Open File' missing from img diff #86392

Open
jrieken opened this issue Dec 5, 2019 · 2 comments
Open

'Open File' missing from img diff #86392

jrieken opened this issue Dec 5, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) git GIT issues help wanted Issues identified as good community contribution opportunities image-preview Built-in image preview extension
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Dec 5, 2019

  • have a image in git
  • make a modification to it
  • the image-editor shows 'Open Changes'
  • open the diff editor for that image
  • 馃悰 the editor still shows 'Open Changes' and not 'Open File'

Screenshot 2019-12-05 at 12 03 00

@bpasero bpasero assigned mjbvz and unassigned bpasero Dec 5, 2019
@mjbvz mjbvz added the custom-editors Custom editor API (webview based editors) label Dec 5, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Jan 23, 2020

Note that this also happens with binary files that don't use custom editors

@mjbvz mjbvz added this to the Backlog milestone Jan 23, 2020
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jan 23, 2020
@bpasero bpasero added the git GIT issues label Jan 23, 2020
@bpasero
Copy link
Member

bpasero commented Jan 23, 2020

This can be explained easily: all commands in Git check for the isInDiffEditor context key which only exists for text diff editor. To fix this properly we need an new key such as isSideBySideEditor whenever the SideBySideEditor is active.

Could probably be done similar to the TextCompareEditorActiveContext key we have for text diff editors.

@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label May 6, 2021
@lszomoru lszomoru self-assigned this Oct 4, 2021
@mjbvz mjbvz added the image-preview Built-in image preview extension label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) git GIT issues help wanted Issues identified as good community contribution opportunities image-preview Built-in image preview extension
Projects
None yet
Development

No branches or pull requests

5 participants