Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate quickSuggestion from editor.action.triggerSuggest #86734

Open
blois opened this issue May 23, 2019 · 3 comments
Open

Disambiguate quickSuggestion from editor.action.triggerSuggest #86734

blois opened this issue May 23, 2019 · 3 comments
Assignees
Labels
suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach

Comments

@blois
Copy link

blois commented May 23, 2019

From a CompletionItemProvider it would be useful to be able to disambiguate completions triggered by quickSuggest and manual invocation of the command (via ctrl-shift). This could be used if specific completions are expensive or particularly low confidence.

Currently quickSuggest suggestions and ctrl-space suggestions both come through with CompletionContext.triggerKind = 0 and triggerCharacter = undefined.

@alexdima alexdima transferred this issue from microsoft/monaco-editor Dec 11, 2019
@mjbvz mjbvz assigned jrieken and unassigned mjbvz Dec 11, 2019
@jrieken jrieken added info-needed Issue requires more information from poster suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach and removed info-needed Issue requires more information from poster labels Dec 11, 2019
@jrieken
Copy link
Member

jrieken commented Dec 11, 2019

Yes - we never saw a need for differentiating between those use-cases whereas the others have concrete ones. So, why do you need to know this?

@blois
Copy link
Author

blois commented Dec 11, 2019

The concrete scenario is that we have completions on code which contains nested languages. The completion logic for the nested language may not be as high quality as the surrounding code so we'd like to only provide completions if the user explicitly requested while inside of the nested context.

An example is a system which provides completions for SQL strings within Javascript such as:
https://www.w3schools.com/nodejs/nodejs_mysql_select.asp

@jrieken
Copy link
Member

jrieken commented Dec 16, 2019

That's an interesting idea but needs some thinking. We have a related request with completions from a fast and slow source, eg. file completions vs project completions, and the same approach good be used there. However, I am afraid that users are confused by such a subtle difference...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants