Regression - JavaScript false positive errors ("Expression expected.")

[ghnp5]

• VSCode Version: 1.41.0
• OS Version: Windows 10

Steps to Reproduce:

<script type="text/javascript">
intVar = <?php echo $someInt; ?>;
someFunction(someArray[<?php echo $someInt; ?>]);
</script>

The first JS line will show error "Expression expected.".
The second JS line will show "An element access expression should take an argument.".

I suppose the JavaScript lint is stripping out the PHP elements before parsing, but in fact, those PHP elements are putting contents where the lint expects them to be.

[aeschli]

Is this with the built-in HTML language support?
We don't support PHP in HTML documents. If it once happen to work, that was just a lucky coincidence.
Instead you have to open the file in PHP mode and have a PHP extension that adds richer language support.
Or you can disable JavaScript validation in HTML, if you want to continue with it like that.

[ghnp5]

Why is this closed?

The file extension is .php and the parsing language in VSCode is PHP.

Why wouldn't you support PHP tags in the middle of HTML? That's very common in many projects... not everyone uses templates like Twig.

[aeschli]

Ah, ok, you are in PHP mode and you are using a PHP extension. You need to file this against the PHP extension you use. VSCode has no rich PHP language support out-of-the-box.

[ghnp5]

The PHP extensions I use are not giving any errors.

It is the built-in JS validator of VSCode that is complaining about invalid JS, in the lines similar to the above.

Do you still think this is something that the PHP extensions need to fix?

[aeschli]

The HTML and/or JS support are only enabled if the editor language mode is HTML or JS.

Can you run VSCode with all extensions disabled?

Here's what I see when I try your example with PHP:

With HTML (errors as expected, PHP code is not HTML):

[bmewburn]

This is probably bmewburn/vscode-intelephense#836

[ghnp5]

Thank you very much.
I raised bmewburn/vscode-intelephense#903 after I saw this error went away when disabling PHP Intelephense.

Oh - I see now it's a duplicate. Thanks for pointing that out, @bmewburn