Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The setting is deprecated. Use editor.codeActionsOnSave instead with a source.fixAll.eslint member. #87227

Closed
prateekgurnani10 opened this issue Dec 18, 2019 · 7 comments

Comments

@prateekgurnani10
Copy link

Whenever I type anything inside my editor, it automatically opens up the json settings. I have no clue why it is doing that

  • VSCode Version: 1.41
  • OS Version: Mac OS catalina 10.15.2
@SathiskumarD
Copy link

Hey Prateek,
can you please let me know how you fixed it?

@sauzy34
Copy link

sauzy34 commented Dec 24, 2019

Hey Prateek,
can you please let me know how you fixed it?
"editor.codeActionsOnSave": { "source.fixAll.eslint": true }

@kissu
Copy link

kissu commented Dec 30, 2019

Not sure why/how but this update also broke my Eslint-Prettier autoformat in .vue files on save.

It's not auto-formatting it when I do save a file, even if "editor.formatOnSave": true, and "vetur.format.defaultFormatter.html": "prettier", has not been changed.

@aurelioolive
Copy link

Correct format:
"editor.codeActionsOnSave": { "source.fixAll.eslint": true }

@kissu
Copy link

kissu commented Dec 30, 2019

I did ofc tried that before too. ^^

@aurelioolive
Copy link

Worked for me o.o

@kissu
Copy link

kissu commented Dec 31, 2019

Exemple, on an old version of VScode on my PC (with synced settings with the latest one, on my laptop), if I change a pug template into html (within an SFC Vue component):

  • the files get converted and all the Eslint warnings are displayed
  • I save the file, each of those are fixed and we do have a final html template length of 182 lines
  • on my laptop, the warnings are just displayed but not corrected once the file is saved (I do need to command panel and run "Format Document") for the same effect to happen.

I do repeat that the settings are synced between both of the editors, only the version is different.

I do have

"editor.formatOnSave": true, 
"javascript.format.enable": true,
"vetur.format.defaultFormatter.js": "prettier", 
"vetur.format.defaultFormatter.html": "prettier", 

Really not sure what screwed up after the update... 🤔

PS: it is heavily struggling but still working for a small number of lines in need for a fix.

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants