Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt problems panel to use views and view container #87245

Merged
merged 6 commits into from Dec 18, 2019
Merged

Adopt problems panel to use views and view container #87245

merged 6 commits into from Dec 18, 2019

Conversation

sandy081
Copy link
Member

This PR fixes #87243

Adoptions:

  • update to body -> layoutBody, renderBody,
  • do not have public render method
  • Memento State
  • Rendering title actions and body are in reverse order
  • Fix when title bar actions are rendered twice

Existing

  • Dispose is not called on hiding panel
  • Cmd+J toggle is not focusing problems

@sandy081 sandy081 added this to the December/January 2020 milestone Dec 18, 2019
@sandy081 sandy081 self-assigned this Dec 18, 2019
@sandy081 sandy081 merged commit 286539c into master Dec 18, 2019
@sandy081 sandy081 deleted the sandy081/moveProblemsToView branch December 18, 2019 11:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
January 2020
Development

Successfully merging this pull request may close these issues.

Adopt problems panel to use views and view containers
1 participant
@sandy081